Re: bootstrap-vz debian package and some other stuff
Hi Tiago,
2015-05-13 5:32 GMT+02:00 Tiago Ilieve <tiago.myhro@gmail.com>:
> Bálint,
>
>> I would happily review and upload your changes as well and thank you for taking care of packaging.
>
> This is awesome! Thanks in advance.
>
> By now I couldn't build the Sphinx documentation on a clean chroot as
> it is using Git to find out the what is last commit and create some
> links using this information. This fails because there isn't a full
> Git repository in there, only the source extracted from the tarball.
Usually we patch similar actions out from the build process and store
the patch under debian/patches/ [3].
If you are interested in packaging you may want to check our
documentation for developers [4], especially the new maintainers'
guide [5].
>
> Anyway, I've already done some small fixes (following the Style Guide
> for Packaging Python Libraries[1]) regarding the current package
> version (0.9.0-2):
>
> * d/control: Update `Build-Depends`, add `dh-python` and remove the
> redundant `python` entry
> * d/control: Update `Depends`, remove `${shlibs:Depends}` to avoid a
> warning during build
> * d/rules: Override `dh_auto_clean` to remove the `*.egg-info`
> directory, which was preventing `debuild` from running more than one
> time
Thanks!
>
> I'm not really sure about how to upload these changes to the package's
> Vcs-Git repository, so I've put them on GitHub[2] until I figure this
> out. I'm also a little bit confused if this dch entry should be
> `0.9.0-3` or `0.9.0-2.1` (Non-Maintainer Upload). I'll wait a little
> more for a reply from Marcin to see if we can work together on this.
You can get write access to the repository by joining the team at [6]
which you are welcome to do.
Cheers,
Balint
[3] https://www.debian.org/doc/manuals/maint-guide/modify.en.html
[4] https://www.debian.org/devel/
[5] https://www.debian.org/doc/manuals/maint-guide/
[6] https://alioth.debian.org/projects/cloud/
>
> Regards,
> Tiago.
>
> [1]: https://wiki.debian.org/Python/LibraryStyleGuide
> [2]: https://github.com/myhro/bootstrap-vz-deb/commits/master
>
> On 12 May 2015 at 14:08, Bálint Réczey <balint@balintreczey.hu> wrote:
>> Hi Tiago,
>>
>> 2015-05-12 18:29 GMT+02:00 Tiago Ilieve <tiago.myhro@gmail.com>:
>>> Hi Marcin and Balint,
>>>
>>> I've been talking with Anders about updating the bootstrap-vz Debian
>>> package. As you may have seen, we've switched the branching
>>> strategy[1] (although missing a new tag to mark the last 0.9.5 release
>>> - we are discussing this) and since the last big merge, most of the
>>> patches made to build it are probably obsolete. He also suggested
>>> using Sphinx to generate the man page automatically and I'm looking
>>> for updating its long description to include keywords like KVM,
>>> Vagrant, etc.
>>>
>>> I'm interested in helping you guys in this task, although I'm not very
>>> experienced in packaging. Can I start doing it and ask you guys to
>>> take a look if everything is working as expected?
>> I serve mostly as a sponsor and review and upload Marcin's changes. I
>> would happily review and upload your changes as well and thank you for
>> taking care of packaging.
>>
>> Cheers,
>> Balint
>>
>>>
>>> Regards,
>>> Tiago.
>>>
>>> [1]: https://lists.debian.org/debian-cloud/2015/05/msg00003.html
>>>
>>> On 30 July 2014 at 14:11, Marcin Kulisz <debian@kulisz.net> wrote:
>>>>
>>>> On 2014-07-30 15:57:08, Olivier Berger wrote:
>>>> > Hi.
>>>>
>>>> Hello,
>>>>
>>>> > I've had a look at the package, and I'd like to suggest the following
>>>> > change.
>>>>
>>>> Thx for this.
>>>>
>>>> > Since the VirtualBox guest additions is packaged in Debian, I would
>>>> > suggest to add it as a suggested package, and to adjust the path of the
>>>> > iso file :
>>>> >
>>>> > virtualbox-vagrant.manifest.yml would then contain :
>>>> > ...
>>>> > provider:
>>>> > name: virtualbox
>>>> > guest_additions: /usr/share/virtualbox/VBoxGuestAdditions.iso
>>>> > ...
>>>>
>>>> Seams to be reasonable. Only small issue is that on master branch there are
>>>> still json files when dev have been converted to yaml. So it should be more
>>>> like this on master:
>>>>
>>>> /manifests/virtualbox-vagrant.manifest.json
>>>> - "guest_additions": "/root/images/VBoxGuestAdditions.iso"
>>>> + "guest_additions": "/usr/share/virtualbox/VBoxGuestAdditions.iso"
>>>> /manifests/virtualbox.manifest.json
>>>> - // "guest_additions": "/root/images/VBoxGuestAdditions.iso"
>>>> + "guest_additions": "/usr/share/virtualbox/VBoxGuestAdditions.iso"
>>>>
>>>> I'll add virtualbox-guest-additions-iso as a suggest to the next build.
>>>>
>>>> > Btw, this leads me to a question : how do you intend to manage potential
>>>> > patches vs upstream sources ?
>>>>
>>>> Patches against upstream are not problem from what I can tell. Anders is very
>>>> capable and easy to talk to so I'm sure we'll be ok on this front.
>>>>
>>>> > Are you using any sort of Git package building tool ? If so, may I
>>>> > suggest to document that somewhere in the debian/READMEs...
>>>>
>>>> I assume you grabbed package from mentors, correct?
>>>> Below entry from d/control should answer your question:
>>>> Vcs-Git: git://anonscm.debian.org/cloud/bootstrap-vz.git
>>>>
>>>> Regarding suggestion to document this, well I could do it as I did it in my
>>>> other package but I'm not sure if it will bring any additional value.
>>>> Let me think about it.
>>>>
>>>> > Hope this helps.
>>>>
>>>> Thx a lot for voicing your opinion, all what helps to make this package better
>>>> is highly appreciated.
>>>>
>>>> BTW no need for cc'ing me in I'm subscribed to the 'cloud list'
>>>> --
>>>>
>>>> |_|0|_| |
>>>> |_|_|0| "Heghlu'Meh QaQ jajVam" |
>>>> |0|0|0| -------- kuLa --------- |
>>>>
>>>> gpg --keyserver pgp.mit.edu --recv-keys 0x58C338B3
>>>> 3DF1 A4DF C732 4688 38BC F121 6869 30DD 58C3 38B3
>>>
>>>
>>>
>>>
>>> --
>>> Tiago "Myhro" Ilieve
>>> Blog: http://blog.myhro.info/
>>> GitHub: https://github.com/myhro/
>>> Montes Claros - MG, Brasil
>
>
>
> --
> Tiago "Myhro" Ilieve
> Blog: http://blog.myhro.info/
> GitHub: https://github.com/myhro/
> Montes Claros - MG, Brasil
Reply to: