[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: TR : Bug#988001: python-fabio: autopkgtest needs update



Dear debian developpers,

I am the upstream maintainer of FabIO and I plead guilty ...

A bug was reported in our reader for the MRC fileformat which  was wrongly
parsing some headers, causing an offset in the image.
https://github.com/silx-kit/fabio/issues/444

The reference "numpy" image was generated with the former code and had
this bug in it. I uploaded the corrected numpy file to our repository at
silx.org without taking care about the side effects. So either you are using the
old code with the new reference image (likely) or an old copy of the
file (many caches exist) with the new code. The fact is there is a bug in FabIO
and now former sources are no more passing the tests.

I see two options:
* Backport the patch from fabio/mrcimage.py one can find in https://github.com/silx-kit/fabio/pull/445/files
* Wait (on me) to make a new release of FabIO, probably at the begining of the summer.

Which option do you prefer ? I am ready to help you with the backport...

Cheers,

Jérôme

On Mon, 3 May 2021 16:43:22 +0000
PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr> wrote:

> Salut Jerome,
> 
> Je viens de recevoir ca.
> 
> Ca te dis quelque chose ?
> 
> Cheers
> 
> Fred
> _______________________________________
> De : debian-science-maintainers [debian-science-maintainers-bounces+picca=synchrotron-soleil.fr@alioth-lists.debian.net] de la part de Graham Inggs [ginggs@debian.org]
> Envoyé : lundi 3 mai 2021 17:02
> À : Debian Bug Tracking System
> Objet : Bug#988001: python-fabio: autopkgtest needs update
> 
> Source: python-fabio
> Version: 0.11.0+dfsg-2
> Severity: serious
> X-Debbugs-CC: debian-ci@lists.debian.org
> User: debian-ci@lists.debian.org
> Usertags: needs-update
> 
> Hi Maintainer
> 
> Sometime around 2021-04-28, python-fabio's autopkgtests started to
> fail in testing [1].
> I've copied what I hope is the relevant part of the log below.
> 
> Regards
> Graham
> 
> 
> [1] https://ci.debian.net/packages/p/python-fabio/
> 
> 
> ======================================================================
> FAIL: test_same (fabio.test.codecs.test_mrcimage.TestMrc)
> see if we can read kcd images and if they are the same as the EDF
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/fabio/test/codecs/test_mrcimage.py",
> line 85, in test_same
>     self.assertAlmostEqual(abs(diff).sum(), 0, 4)
> AssertionError: 518.96295 != 0 within 4 places (518.9629516601562 difference)
> 
> ----------------------------------------------------------------------
> Ran 337 tests in 322.428s
> 
> FAILED (failures=1, skipped=17)
> ...
> /tmp/fabio_d99wjnej_debci/lima3d.h5
> speed-up: 8.013895911681718
> ##### 0
> ##### 1
> ##### 2
> ##### 3
> ##### 4
> ##### 5
> ##### 6
> ##### 7
> autopkgtest [10:37:05]: test command1: -----------------------]
> autopkgtest [10:37:05]: test command1:  - - - - - - - - - - results -
> - - - - - - - - -
> command1             FAIL non-zero exit status 1
> 
> --
> debian-science-maintainers mailing list
> debian-science-maintainers@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-science-maintainers


Reply to: