Bug#976047: shoogle: flaky autopkgtest on ci.debian.net and missing needs-internet restriction
Source: shoogle
Version: 0.1.4-9
Severity: serious
X-Debbugs-CC: debian-ci@lists.debian.org
User: debian-ci@lists.debian.org
Usertags: flaky
Control: affects -1 python3-defaults
Dear maintainer(s),
shoogle has an autopkgtest, great. However, it fails more often than it
passes [1].
Because the unstable-to-testing migration software now blocks on
regressions in testing, flaky tests, i.e. tests that flip between
passing and failing without changes to the list of installed packages,
are causing people unrelated to your package to spend time on these
tests.
I copied the output at the bottom of this report. Can you please look
into it and make the test more robust (against network issues). If you
keep the test that requires internet, you should add the needs-internet
restriction too.
Paul
[1] https://ci.debian.net/packages/s/shoogle/testing/amd64/
[2] https://ci.debian.net/packages/s/shoogle/testing/arm64/
https://ci.debian.net/data/autopkgtest/testing/amd64/s/shoogle/8333563/log.gz
======================================================================
FAIL: test_main_execute_with_missing_parameter
(tests.test_shoogle.TestShoogle)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/tmp/autopkgtest-lxc.es_gm45h/downtmp/build.BYz/src/tests/test_shoogle.py",
line 158, in test_main_execute_with_missing_parameter
self.assertIn('Missing required parameter "task"', e.err)
AssertionError: 'Missing required parameter "task"' not found in
'/tmp/autopkgtest-lxc.es_gm45h/downtmp/build.BYz/src/shoogle/common.py:34:
ResourceWarning: unclosed <ssl.SSLSocket fd=5,
family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6,
laddr=(\'192.168.122.75\', 40990), raddr=(\'172.217.168.234\', 443)>\n
apis =
download("https://www.googleapis.com/discovery/v1/apis";)\nResourceWarning:
Enable tracemalloc to get the object allocation
traceback\n/tmp/autopkgtest-lxc.es_gm45h/downtmp/build.BYz/src/shoogle/common.py:64:
ResourceWarning: unclosed <ssl.SSLSocket fd=5,
family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6,
laddr=(\'192.168.122.75\', 35478), raddr=(\'216.58.208.106\', 443)>\n
service_json = download(service["discoveryRestUrl"])\nResourceWarning:
Enable tracemalloc to get the object allocation traceback\n[ERROR]
googleapiclient.discovery: Missing required parameter "tasklist"\n'
----------------------------------------------------------------------
Ran 12 tests in 5.137s
FAILED (failures=1)
Test failed: <unittest.runner.TextTestResult run=12 errors=0 failures=1>
error: Test failed: <unittest.runner.TextTestResult run=12 errors=0
failures=1>
autopkgtest [12:10:55]: test test-unittest: -----------------------]
Reply to: