[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#910734: dpkg-source: please expand @builddeps@ in Testsuite-Triggers



Hi,

On 11-10-18 15:31, Paul Gevers wrote:
> I'll try to do a more thorough check, but if I read the code in britney2
> (both versions) correctly, britney2 is already safe for this change. It
> doesn't treat names in this list in any special way and will happily
> take invalid package names including packages named '@' or
> '@builddeps@'. Where the values are (currently) used it is iterating
> over real packages, so it will not actually use the invalid ones.

I just ran one of the testsuites with "Testsuite-Triggers: @builddeps@"
littered into all source packages. The suite ran fine, as expected.

So I think we are good to go. I think dpkg-source should just add all
the unique items found in the test dependencies to the
Testsuite-Triggers. That way, it doesn't need to know and adjust for any
future change in that field.

Paul

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: