[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#904776: /usr/bin/dpkg-source: please parse d/t/control.autodep8 like d/t/control

Control: tags -1 moreinfo


On Fri, 2018-07-27 at 22:04:24 +0200, Paul Gevers wrote:
> Package: dpkg-dev
> Version:
> Severity: normal
> File: /usr/bin/dpkg-source
> X-Debbugs-CC: debian-ci@lists.debian.org, python-cobra@packages.debian.org
> User: debian-ci@lists.debian.org
> Usertags: issue
> Control: affects -1 src:python-cobra

> In commit 90324cf support was added to dpkg-source to read debian/tests/control
> files and convert all test dependencies into a Testsuite-Triggers field. This
> works great and is used by britney to do unstable-to-testing migration
> tests. However, we recently spotted a regression (in python-cobra) that was
> missed, because it uses autodep8 with additional test cases. This is done in
> line with the autodep8(1) man page¹:
> '''
>        If `debian/tests/control.autodep8` exists, autodep8 will prepend the
>        contents of that file to its own output. In that case, autodep8 will
>        exit with a status of 0 even if no known package type is detected.
> '''
> It would be great if dpkg-source would also parse debian/tests/control.autodep8
> in the same way as it does debian/tests/control, except I guess it should not
> set the Testsuite field (as dpkg-source doesn't know which type of autopkgtest
> this is).

Hmm, why did we get this new file at all? Why can't we use
debian/tests/control instead? The Testsuite field would be used to
specify that we still want autodep8 to be run, no?


Reply to: