I proudly present: first version of apt-release
- Subject: I proudly present: first version of apt-release
- From: mpitt@debian.org (Martin Pitt)
- Date: Sun, 17 Sep 2017 21:37:53 +0200
- Message-id: <[🔎] 20170917193752.GA1024@donald>
- In-reply-to: <a0fe545d-3ee2-e931-712b-92ebb1b2b294@debian.org>
- References: <2b462e26-aadc-9d22-fc52-3b90217f4f3f@debian.org> <20170126125025.GB1425@donald> <c99b55f6-7797-8ffa-eb31-d531fc688ed9@debian.org> <a0fe545d-3ee2-e931-712b-92ebb1b2b294@debian.org>
Hello Paul,
Paul Gevers [2017-08-08 21:17 -0400]:
> >> FYI, Simon propopsed a more generic way to add an entire apt line in #851568,
> >> which then would resolve any ambiguity like the ones above. The charm of
> >> --apt-pocket is that it can stay a hardcoded value in a CI system, but the same
> >> won't really extend for full series names. So maybe for this having an
> >> --apt-source which gets the full line (maybe with some magic <mirror>
> >> replacement from the existing apt sources) might be both more flexible and less
> >> confusing?
> >
> > I'll let that idea sink in. I think that would mean that we would treat
> > --apt-pocket and --apt-source quite different again, but maybe that
> > isn't too bad.
>
> I decided to build my implementation on this idea. For that to work I
> needed to do some things slightly different for -pockets as well, but I
> believe in a better way. Could you please comment on my work and see how
> you like it now?
>
> Paul
>
> ? https://github.com/paulgevers/autopkgtest/tree/gating-via-sources
I think the general direction of that is fine. I commented on the github
commits, as that's a rather convenient place. However, that wasn't ideal either
as a lot of the commits belong together or change previous commits; OTOH,
diffing your branch against master (to get the complete picture) is also a bit
difficult as they diverted a bit. Can you please rebase your branch against
master and squash related commits together? (Like defining an option,
implementing it, and the corresponding test case).
Indeed --apt-pocket and --apt-source are now quite different, I don't see how
to efficiently merge them or reimplement --apt-pocket "on top of"
--apt-source. But I think that's ok, as long as both have proper tests.
Thanks!
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20170917/0afa1446/attachment.sig>
Reply to: