Bug#844459: autopkgtest: Please add autopkgtest-virt-uchroot
Johannes Schauer [2016-12-08 16:53 +0100]:
> > > Should sbuild expect that
> > > after the user presses Ctrl+C, the autopkgtest backend takes care to completely
> > > shut down the backend by itself? I don't think this is a viable option because
> > > the autopkgtest backend used by sbuild might be one that carries over changes
> > > made by sbuild to the next session. And in that cases, the session must not
> > > just close under sbuild's feet but sbuild must be given the chance to clean up
> > > after itself after the user cancelled the build with Ctrl+C.
> >
> > I don't think that autopkgtest's schroot runner is at all appropriate
> > for this -- sbuild already creates the chroot and wants to clean it
> > up, and autopkgtest shouldn't
>
> Are you saying that this incompatibility affects all autopkgtest backends that
> offer the "revert" capability? That would mean that the problem is not limited
> to the schroot backend. It would mean that the sbuild autopkgtest backend
> cannot be used reliably (that is - also support the user sending a SIGINT to
> the sbuild process group) with any backend that offers "revert". That would for
> example include the very useful qemu or lxc backends.
>
> I do not understand your argument why you do not find autopkgtest's schroot
> runner appropriate for this. Can you elaborate? Sbuild doesn't create the
> chroot at all.
Maybe I misunderstood you above, but you said that sbuild was creating
the "session", which I assumed was the schroot session that it uses
to build the package and run its autopkgtest in.
If sbuild *does* control the schroot session, then it's not autopkgtest's
business to control (revert/stop) it.
If sbuild does *not* control the schroot session, then I'm afraid I
don't understand the problem -- autopkgtest should receive the ^C,
clean up, then exit, and sbuild either sees that it exited and can then do its
cleanup or it receives the SIGINT by itself and does its cleanup in
parallel.
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20161208/ae7e2f41/attachment.sig>
Reply to: