[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#800845: autopkgtest: Add support for nested VMs


On 03/04/2016 09:31 PM, Martin Pitt wrote:
> Fixed the fd leak, some code style, PEP-8, and massaged the changelog:
>   http://anonscm.debian.org/cgit/autopkgtest/autopkgtest.git/commit/?id=3a9cb0b9

There's a small bug in the changes you made to my patch: logging.warning
should be adtlog.warning. Also, technically you missed a return path in
get_cpuflag(), since /proc/cpuinfo could contain no line that starts with

I've attached a patch that fixes that for me.

While test-building I also noticed quite a few lintian informational
notices about the manpages (mainly hyphen-used-as-minus-sign), but also
some spelling errors. If you want, I can provide a patch that fixes
all of those.

(Also note that lintian gives me:
W: autopkgtest: executable-not-elf-or-script usr/share/autopkgtest/setup-commands/ubuntu-touch-session
W: autopkgtest: executable-not-elf-or-script usr/share/autopkgtest/setup-commands/ro-apt
W: autopkgtest: executable-not-elf-or-script usr/share/autopkgtest/setup-commands/ro-apt-update
There are no shebangs in there: is that intentional?)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixup-cpuflags.patch
Type: text/x-diff
Size: 735 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20160304/54feaa1b/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20160304/54feaa1b/attachment.sig>

Reply to: