where to maintain DEP8^W autopkgtest spec now
- Subject: where to maintain DEP8^W autopkgtest spec now
- From: jwilk@debian.org (Jakub Wilk)
- Date: Sun, 19 Oct 2014 22:38:38 +0200
- Message-id: <[🔎] 20141019203838.GA8529@jwilk.net>
- In-reply-to: <[🔎] 20141005215214.GA15290@upsilon.cc>
- References: <20140722102646.GA28835@upsilon.cc> <20140723205914.GA13780@debian.org> <20140724160123.GA11819@upsilon.cc> <87zjfy67jf.fsf@windlord.stanford.edu> <20140725102346.GA7005@upsilon.cc> <20140728163235.GD3463@piware.de> <20140729092926.GA30035@upsilon.cc> <8761igksw0.fsf@windlord.stanford.edu> <20140731115350.GA19913@upsilon.cc> <[🔎] 20141005215214.GA15290@upsilon.cc>
Here's my review of the proposed policy patch:
* Stefano Zacchiroli <zack at debian.org>, 2014-10-05, 23:52:
>Tests may not modify the source tree (and may not have write access to
>it).
"may not" may be ambiguous; and in fact the second instance _is_
ambiguous. How about:
Tests must not modify the source tree (and might not have write access
to it).
?
>When using the `--output-dir` option, they will be copied into
>`outputdir/artifacts/`.
I don't think command-line interface of adt-run belongs in policy. Maybe
this sentence should be moved to a footnote.
>- **Test-Command:** *shell command*
>
>If your test only contains a shell command or two, or you want to
>re-use an existing upstream test executable and just need to wrap it
>with some command like `dbus-launch` or `env`, you can use this field
>to specify the shell command directly. It will be run under `bash -e`.
Huh, why bash?
>- **Classes:** *class-1, class-2, ...*
[...]
>This is purely an informational field for autopkgtest itself and will
>be ignored.
What does "autopkgtest" mean here? The "autopkgtest" package, or
something else?
>Any unknown fields will cause the whole stanza to be skipped.
This has always baffled me. I don't know any other Debian control file
with this behavior. If there's method in this madness, then it would be
good to explain what the method is. :-)
It would be probably good to decide if it's "virtualisation" or
"virtualization".
You added evil tabs to debian/control. Please use spaces instead. :-)
--
Jakub Wilk
Reply to: