Re: cxterm-5.1 patch

["ZHUANG, Hao" <hz69@columbia.edu>]

Thank you very much for your patch. Actually another guy found
a bug while select the text with mouse. I've patched that also.
I'll try to test it on other platforms and put the new one on
ftp.

The kernel is 2.0.36. Maybe I'm too sleepy last night.. :)

Thanks !

Anthony Wong wrote:
> Hi Zhuang Hao,
> 
> I can't believe that cxterm is still being improved, thanks for the
> work!
> But there's some small errors when I tried to compiled it on my
> glibc2.1 linux box. Here is the patch:
> 
> ===============================
> diff -uNr cxterm-5.1/cxterm/screen.c cxterm-5.1.modified/cxterm/screen.c
> --- cxterm-5.1/cxterm/screen.c  Fri Jun  4 09:59:41 1999
> +++ cxterm-5.1.modified/cxterm/screen.c Sat Jun  5 03:58:10 1999
> @@ -54,7 +54,8 @@
>  #include <sys/ptem.h>
>  #endif
> 
> -extern Char *calloc(), *malloc(), *realloc();
> +/* This is not necessary as they are defined in stdlib.h */
> +/* extern Char *calloc(), *malloc(), *realloc(); */
>  extern void free();
>  #ifdef HANZI
>  extern HZ_XDrawImString16();
> diff -uNr cxterm-5.1/cxterm/scrollbar.c cxterm-5.1.modified/cxterm/scrollbar.c
> --- cxterm-5.1/cxterm/scrollbar.c       Fri Jun  4 09:59:41 1999
> +++ cxterm-5.1.modified/cxterm/scrollbar.c      Sat Jun  5 04:02:26 1999
> @@ -323,7 +323,9 @@
>         register TScreen *screen = &xw->screen;
>         register int border = 2 * screen->border;
>         register int i;
> -       Char *realloc(), *calloc();
> +/*  This should not be necessary because they don't match the
> +    declarations in stdlib.h */
> +/*     Char *realloc(), *calloc(); */
> 
>         if(screen->scrollbar)
>                 return;
> ===============================
> 
> My system config is:
> Debian unstable (potato), libc6 2.1.1-10, Linux version 2.2.5-ac1
> 
> In your FTP site you said
>     Linux Debian (slink, kernel 2.0.39)
> 
> Is it really 2.0.39? I think it doesn't exist!
> 
> --
> Anthony Wong.   [ E-mail: hajime@asunaro.dhs.org / ypwong@debian.org ]

-- 
     _________________________________________________________________
    /\                                                                \
    \| ZHUANG Hao <hz69@columbia.edu> http://ctr.columbia.edu/~jerrey |
     | -------------------------------------------------------------- |
     |  Electrical Engineering       :    526 W112th Street, Apt 62   |
     |  Columbia University          :    New York, NY 10025          |
     |  Tel:  212-932-1689 (H)       :    ICQ UIN: 19613067           |
     | _______________________________________________________________|_
     \/________________________________________________________________/