[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: broken kfreebsd cdimage building

Cyril Brulebois:
> Robert Millan <rmh@debian.org> (2013-09-26):
>>> so you broke cdimage building for kfreebsd-*: 
>>> http://anonscm.debian.org/gitweb/?p=d-i/debian-installer.git;a=commitdiff;h=c5a8de108e7828cc3e2694309cbb045eb8db521c
>> http://anonscm.debian.org/gitweb/?p=d-i/debian-installer.git;a=commitdiff;h=c5a8de108e7828cc3e2694309cbb045eb8db521c
>> No, this is correct. kfreebsd-8 is considered obsolete and won't be
>> included in Jessie. See:
>> https://lists.debian.org/debian-bsd/2013/08/msg00175.html
> You're missing the point. I'm not saying the changes are incorrect. I'm
> saying they broke cdimage building, which you get to fix by sending
> patches.
> That's called coordinating changes. You really should have done that…

Oh yes. I have to admit, despite my best efforts I can't always keep
track with every detail. It's fortunate that we can rely on you to send
reminders, I really appreciate that.

Here, attached patch should get jessie builds working again. Would you
be kind enough to commit it?

Robert Millan
Index: tools/boot/jessie/boot-kfreebsd
--- tools/boot/jessie/boot-kfreebsd	(revision 2572)
+++ tools/boot/jessie/boot-kfreebsd	(working copy)
@@ -40,7 +40,7 @@
 # Download boot images.
-BOOT_IMAGES="cdrom/debian-cd_info.tar.gz cdrom/kfreebsd.gz cdrom/kfreebsd-9.gz cdrom/initrd.gz"
+BOOT_IMAGES="cdrom/debian-cd_info.tar.gz cdrom/kfreebsd-9.gz cdrom/initrd.gz"
 if [ "$ARCH" = kfreebsd-amd64 ]; then
 	BOOT_IMAGES="$BOOT_IMAGES cdrom/gtk/initrd.gz"
@@ -63,10 +63,7 @@
 # Install kernel and initrd
 mkdir -p $CDDIR/boot/kernel/
-cp "cdrom/kfreebsd.gz" "$CDDIR/boot/kernel/kfreebsd.gz"
-if [ -f cdrom/kfreebsd-9.gz ] ; then
-   cp "cdrom/kfreebsd-9.gz" "$CDDIR/boot/kernel/kfreebsd-9.gz"
+cp "cdrom/kfreebsd-9.gz" "$CDDIR/boot/kernel/kfreebsd-9.gz"
 cp "cdrom/initrd.gz" "$CDDIR/boot/mfsroot.gz"
 if [ "$ARCH" = kfreebsd-amd64 ] && [ -f cdrom/gtk/initrd.gz ] ; then

Reply to: