Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.

[Frans Pop <elendil@planet.nl>]

(No need to CC me on replies.)

On Friday 07 August 2009, Ian Campbell wrote:
>  show_usage() {
> -       echo "Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all] BC|NETINST|CD|DVD [<ARCH> ...]"
> +       echo "Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all] [-v VARIANTS] BC|NETINST|CD|DVD [<ARCH> ...]" }

This line is getting too long now. Suggest changing it to:
echo "Usage: $(basename $0) [OPTIONS] BC|NETINST|CD|DVD [<ARCH> ...]"
echo "  Options:"
echo "     -d gnome|kde|lxde|xfce|light|all : desktop variant (task) to use"
echo "     -v <variant> : ..."
echo "     -h help"
 
> @@ -25,7 +25,8 @@ if [ $# -eq 0 ]; then
>  fi
>  
>  desktop=
> -while getopts d:h OPT ; do
> +VARIANTS=
> +while getopts d:hV: OPT ; do

Why capital V instead of lower case v as shown in usage?

>         case $OPT in
>             d)
>                 case $OPTARG in
> @@ -38,11 +39,13 @@ while getopts d:h OPT ; do
>                         exit 1
>                         ;;
>                 esac ;;
> +           V) VARIANTS="$VARIANTS $OPTARG" ;;

Idem.