Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.

To: Ian Campbell <ijc@hellion.org.uk>
Cc: Frans Pop <elendil@planet.nl>, debian-cd@lists.debian.org, debian-boot@lists.debian.org
Subject: Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.
From: Julien Cristau <jcristau@debian.org>
Date: Fri, 7 Aug 2009 15:24:23 +0200
Message-id: <[🔎] 20090807132423.GO3954@patate.is-a-geek.org>
Mail-followup-to: Julien Cristau <jcristau@debian.org>, Ian Campbell <ijc@hellion.org.uk>, Frans Pop <elendil@planet.nl>, debian-cd@lists.debian.org, debian-boot@lists.debian.org
In-reply-to: <[🔎] 1249648413.19411.151.camel@zakaz.uk.xensource.com>
References: <[🔎] 1249627178.21313.1465.camel@localhost.localdomain> <[🔎] 1249627295-27145-2-git-send-email-ijc@hellion.org.uk> <[🔎] 200908071405.52694.elendil@planet.nl> <[🔎] 1249648413.19411.151.camel@zakaz.uk.xensource.com>

Hi,

one nitpick:

On Fri, Aug  7, 2009 at 13:33:33 +0100, Ian Campbell wrote:

> +shift $(expr $OPTIND - 1)
>  
maybe 'shift $((OPTIND - 1))' so you don't fork expr?

Cheers,
Julien

Reply to:

References:
- Install from ISO for Xen guest
  - From: Ian Campbell <ijc@hellion.org.uk>
- [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.
  - From: Ian Campbell <ijc@hellion.org.uk>
- Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.
  - From: Frans Pop <elendil@planet.nl>
- Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.
  - From: Ian Campbell <ijc@hellion.org.uk>

Prev by Date: Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.
Next by Date: Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
Previous by thread: Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.
Next by thread: [PATCH 3/4] Add support for producing disks with (optional) extra variants.
Index(es):
- Date
- Thread