Bug#503911: update-cd creates extra directories

[Steve McIntyre <steve@einval.com>]

tags 503911 +pending
thanks

On Wed, Oct 29, 2008 at 02:23:31PM +0530, S P wrote:
>Package: debian-cd
>Version: 3.0.5
>
>On the debian 4.0 r5 Update DVDs, the pool structure generated
>contains some package files mistakenly placed in their own
>directories.
>
>For example:
>
>$ ls -FR pool/contrib/b/b43-fwcutter/
>pool/contrib/b/b43-fwcutter/:
>b43-fwcutter_011-1~etchnhalf.2_amd64.deb/
>
>pool/contrib/b/b43-fwcutter/b43-fwcutter_011-1~etchnhalf.2_amd64.deb:
>b43-fwcutter_011-1~etchnhalf.2_amd64.deb
>
>As noted by Steve McIntyre on the debian-cd mailing list [1], this is
>purely a cosmetic bug.
>
>It occurs because the code that strips the filename in the copy_file
>function (in update-cd) uses a regular expression that does not
>include the "~" character.
>
> DIR=`echo $FILE | sed 's?/[-_\.A-Za-z0-9\+]*$??'`
>
>Adding the ~ character should solve the problem (not tested, sorry!):
>
> DIR=`echo $FILE | sed 's?/[-_\.~A-Za-z0-9\+]*$??'`
>
>Or perhaps dirname is a better alternative?
>
> DIR=`dirname "$FILE"`

Yes, you're right. dirname is clearly the right answer. Fixed in svn,
will be in the next package upload.

Thanks for your bug report!

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
< liw> everything I know about UK hotels I learned from "Fawlty Towers"