[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#503722: debian-cd: Comment "workaround for bug #402482" is WRONG



On Mon, Oct 27, 2008 at 04:43:40PM -0400, David F. Skoll wrote:
>Package: debian-cd
>Version: 3.0.2
>Severity: important
>
>In the file tools/make_disc_trees.pl in debian-cd-3.0.2, we see this:
>
>sub md5_files_for_release {
>    my ($md5, $size, $filename);
>
>    $filename = $File::Find::name;
>
>    # Recompress the Packages and Sources files; workaround for bug
>    # #402482
>    if ($filename =~ m/\/.*\/(Packages|Sources)$/o) {
>        system("gzip -9c < $_ >$_.gz");
>    }
>... rest deleted
>
>The function is invoked as:
>
>    find (\&md5_files_for_release, ".");
>
>The PROBLEM is that if Packages.gz exists, and is found BEFORE Packages,
>you wind up with a corrupt Release file!  "find" does NOT sort its
>files, so this can happen if you're unlucky.

Hi David,

Maybe I'm being dense here, but I don't think that
m/\/.*\/(Packages|Sources)$/o is going to match a file called
Packages.gz.

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
"Since phone messaging became popular, the young generation has lost the
 ability to read or write anything that is longer than one hundred and sixty
 characters."  -- Ignatios Souvatzis




Reply to: