[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#503722: debian-cd: Comment "workaround for bug #402482" is WRONG



Package: debian-cd
Version: 3.0.2
Severity: important

In the file tools/make_disc_trees.pl in debian-cd-3.0.2, we see this:

sub md5_files_for_release {
    my ($md5, $size, $filename);

    $filename = $File::Find::name;

    # Recompress the Packages and Sources files; workaround for bug
    # #402482
    if ($filename =~ m/\/.*\/(Packages|Sources)$/o) {
        system("gzip -9c < $_ >$_.gz");
    }
... rest deleted

The function is invoked as:

    find (\&md5_files_for_release, ".");

The PROBLEM is that if Packages.gz exists, and is found BEFORE Packages,
you wind up with a corrupt Release file!  "find" does NOT sort its
files, so this can happen if you're unlucky.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)

Versions of packages debian-cd depends on:
ii  apt                      0.6.46.4-0.1    Advanced front-end for dpkg
ii  bc                       1.06-20         The GNU bc arbitrary precision cal
ii  cpp                      4:4.1.1-15      The GNU C preprocessor (cpp)
ii  genisoimage              9:1.1.2-1       Creates ISO-9660 CD-ROM filesystem
ii  grep-dctrl               2.9.3           Grep Debian package information - 
ii  libcompress-zlib-perl    1.42-2          Perl module for creation and manip
ii  lynx                     2.8.5-2sarge2.2 Text-mode WWW Browser
ii  make                     3.81-2          The GNU version of the "make" util
ii  mkisofs                  9:1.1.2-1       Dummy transition package for genis
ii  perl [libdigest-md5-perl 5.8.8-7etch3    Larry Wall's Practical Extraction 
ii  tofrodos                 1.7.6-2         Converts DOS <-> Unix text files, 

Versions of packages debian-cd recommends:
pn  hfsutils               <none>            (no description available)
ii  netpbm                 2:10.0-11.1+etch1 Graphics conversion tools
ii  syslinux               1:3.31-4          Bootloader for Linux/i386 using MS

-- no debconf information



Reply to: