[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#824451: libarchive: FTBFS on kFreeBSD: tar/test/test_option_older_than.c:70: File should exist



[Andreas Henriksson]
> In my ears this sounds pretty much like we're either:
>
> a/ working around a really serious potential data loss bug in kfreebsd
> b/ hiding a race in the testsuite by making it less likely to trigger
>
> Neither really sounds like we're getting the correct fix, but maybe
> I'm wrong.

Would be useful if some kFreeBSD expert would comment on this. :)

> Could you please advice on what your ideas about the patch is/was?
> Just suggesting where the problem might be and provide a workaround or
> do you consider the patch the correct fix for the problem?

The idea was that if the kernel for some reason (performance, perhaps)
was not commiting the file to the file system before access() was
looking for it, it would help to tell the kernel that the change should
be commited using fsync().  My idea was that different processes were
involved, but on closer investigation I doubt that is the case.  I
suspect posix require that open/write/close should cause a following
access() to see the freshly created file, but can not quite which
requirement that would be. :)
-- 
Happy hacking
Petter Reinholdtsen


Reply to: