[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: kfreebsd-amd64: monitor test hangs in _kqueue_thread_func()



tags 734290 patch
thanks

On 05/01/2014 17:55, Robert Millan wrote:
> Package: glib2.0
> Version: 2.38.2-1
> Severity: important
> User: debian-bsd@lists.debian.org
> Usertags: kfreebsd
> 
> monitor test hangs when running the testsuite on kfreebsd-amd64 (using glibc 2.18).

Please consider attached patch. This will convert hangs into harmless warnings
and make it possible to run the testsuite on kfreebsd again.

It should make things a lot less painful for you, as kfreebsd test failures no
longer break the build this way.

Then we can prioritize the test failures based on their severity/impact rather
than based on whether they cause FTBFS.

-- 
Robert Millan
diff -Nur -x .pc glib2.0-2.38.2/debian/patches/series glib2.0-2.38.2.new/debian/patches/series
--- glib2.0-2.38.2/debian/patches/series	2013-12-14 15:27:57.000000000 +0100
+++ glib2.0-2.38.2.new/debian/patches/series	2014-01-05 22:25:48.000000000 +0100
@@ -11,3 +11,4 @@
 61_glib-compile-binaries-path.patch
 90_gio-modules-multiarch-compat.patch
 skip-brokwn-dbus-appinfo-test.patch
+timeout.patch
diff -Nur -x .pc glib2.0-2.38.2/debian/patches/timeout.patch glib2.0-2.38.2.new/debian/patches/timeout.patch
--- glib2.0-2.38.2/debian/patches/timeout.patch	1970-01-01 01:00:00.000000000 +0100
+++ glib2.0-2.38.2.new/debian/patches/timeout.patch	2014-01-05 22:23:03.000000000 +0100
@@ -0,0 +1,10 @@
+Index: glib2.0-2.38.2.new/tap-test
+===================================================================
+--- glib2.0-2.38.2.new.orig/tap-test	2013-11-07 16:29:13.000000000 +0100
++++ glib2.0-2.38.2.new/tap-test	2014-01-05 22:22:30.000000000 +0100
+@@ -2,4 +2,4 @@
+ 
+ # run a GTest in tap mode. The test binary is passed as $1
+ 
+-$1 -k --tap
++timeout 600 $1 -k --tap
diff -Nur -x .pc glib2.0-2.38.2/debian/rules glib2.0-2.38.2.new/debian/rules
--- glib2.0-2.38.2/debian/rules	2013-12-14 15:25:47.000000000 +0100
+++ glib2.0-2.38.2.new/debian/rules	2014-01-05 22:23:57.000000000 +0100
@@ -61,6 +61,8 @@
 
 ifeq ($(DEB_HOST_ARCH_OS), linux)
   DEB_MAKE_CHECK_TARGET = $(if $(filter deb, $(cdbs_make_curflavor)), -k check)
+else
+  DEB_MAKE_CHECK_TARGET = $(if $(filter deb, $(cdbs_make_curflavor)), -k check || true)
 endif
 
 # The tests assume this directory exists and is writable
diff -Nur -x .pc glib2.0-2.38.2/tap-test glib2.0-2.38.2.new/tap-test
--- glib2.0-2.38.2/tap-test	2013-11-07 16:29:13.000000000 +0100
+++ glib2.0-2.38.2.new/tap-test	2014-01-05 22:22:30.000000000 +0100
@@ -2,4 +2,4 @@
 
 # run a GTest in tap mode. The test binary is passed as $1
 
-$1 -k --tap
+timeout 600 $1 -k --tap
diff -Nur -x .pc glib2.0-2.38.2/tap-test~ glib2.0-2.38.2.new/tap-test~
--- glib2.0-2.38.2/tap-test~	1970-01-01 01:00:00.000000000 +0100
+++ glib2.0-2.38.2.new/tap-test~	2013-11-07 16:29:13.000000000 +0100
@@ -0,0 +1,5 @@
+#! /bin/sh
+
+# run a GTest in tap mode. The test binary is passed as $1
+
+$1 -k --tap

Reply to: