[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#699704: partman: Please don't load_extra on non-Linux



Control: tag -1 pending

Steven Chamberlain <steven@pyro.eu.org> (05/03/2013):
> On 05/03/13 20:31, Cyril Brulebois wrote:
> > Want me to commit your patch to git, and upload that?
> 
> Yes, please!  I almost forgot about this...

No worries. Lagging behind, but trying to read all bug mail…

If the changelog message looks OK to you, I'll upload that later
tonight.

Mraw,
KiBi.
commit 24c76fe8cb7cc85475dd85825455624c147c3630
Author: Cyril Brulebois <kibi@debian.org>
Date:   Tue Mar 5 21:48:28 2013 +0100

    Skip load_extra on GNU/kFreeBSD and GNU/Hurd (Closes: #699704).
    
    Let's avoid loading extra components which cannot work due to missing
    dependencies (notably partman-*lvm is missing lvm2-udeb on non-Linux
    architectures); this should avoid running out of space on the
    (non-resizable) rootfs on GNU/kFreeBSD (Closes: #699704). Thanks, Steven
    Chamberlain!

diff --git a/debian/changelog b/debian/changelog
index 52db215..d30cd14 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+partman-base (164) UNRELEASED; urgency=low
+
+  * Skip load_extra on GNU/kFreeBSD and GNU/Hurd to avoid loading extra
+    components which cannot work due to missing dependencies (notably
+    partman-*lvm is missing lvm2-udeb on non-Linux architectures); this
+    should avoid running out of space on the (non-resizable) rootfs on
+    GNU/kFreeBSD (Closes: #699704). Thanks, Steven Chamberlain!
+
+ -- Cyril Brulebois <kibi@debian.org>  Tue, 05 Mar 2013 21:39:39 +0100
+
 partman-base (163) unstable; urgency=low
 
   * Revert "add debhelper token to postinst"
diff --git a/partman b/partman
index c993b94..c1ff4ad 100755
--- a/partman
+++ b/partman
@@ -15,6 +15,14 @@ abort () {
 load_extra () {
 	local auto memreq_lvm memreq_crypto
 
+	# These packages currently are of no use on GNU/kFreeBSD or GNU/Hurd,
+	# but do waste a lot of space, so skip installing them here
+	case "$(udpkg --print-os)" in
+	kfreebsd|hurd)
+		return 0
+		;;
+	esac
+
 	if [ -f /var/lib/partman/loaded-extra ]; then
 		return 0
 	fi

Attachment: signature.asc
Description: Digital signature


Reply to: