Re: Bug#696514: freebsd-net-tools: /sbin/ifconfig: segfaults getting bridge status
Control: tags -1 + patch
Control: unblock -1 by 685625
Hi,
On 22/12/12 02:32, Steven Chamberlain wrote:
>> cc -Wall -g -pipe -fPIC -I. -D_GNU_SOURCE -D__va_list=__builtin_va_list -isystem /usr/include/tirpc -D__FreeBSD_version=__FreeBSD_kernel_version -O2 -isystem /usr/include/freebsd -I/build/buildd-freebsd-utils_9.0+ds1-8-kfreebsd-i386-vUpCIn/freebsd-utils-9.0+ds1/debian/local/include -I/build/buildd-freebsd-utils_9.0+ds1-8-kfreebsd-i386-vUpCIn/freebsd-utils-9.0+ds1/include -lbsd -DINET6 -DINET -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wnested-externs -Wall -g -pipe -fPIC -I. -D_GNU_SOURCE -D__va_list=__builtin_va_list -isystem /usr/include/tirpc -D__FreeBSD_version=__FreeBSD_kernel_version -O2 -std=gnu99 -fstack-protector -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c ifbridge.c
>> ifbridge.c: In function 'bridge_addresses':
>> ifbridge.c:241:3: warning: implicit declaration of function 'ether_ntoa' [-Wimplicit-function-declaration]
This can be fixed by including the appropriate header.
Curiously it doesn't seem related to libbsd or freebsd-glue: it is not
one of the <bsd/*.h> headers that seems to be missing this time.
Regards,
--
Steven Chamberlain
steven@pyro.eu.org
Index: freebsd-utils-9.0+ds1/sbin/ifconfig/ifbridge.c
===================================================================
--- freebsd-utils-9.0+ds1.orig/sbin/ifconfig/ifbridge.c 2007-11-04 08:32:27.000000000 +0000
+++ freebsd-utils-9.0+ds1/sbin/ifconfig/ifbridge.c 2012-12-29 20:27:46.888636491 +0000
@@ -46,6 +46,8 @@
#include <stdlib.h>
#include <unistd.h>
+#include <netinet/ether.h> /* for ether_aton, etherntoa */
+
#include <net/ethernet.h>
#include <net/if.h>
#include <net/if_bridgevar.h>
Reply to: