Re: Bug#692992: FTBFS on kfreebsd-*
On Mon, 2012-11-12 at 15:03:20 +0100, Michael Biebl wrote:
> On 12.11.2012 03:24, Guillem Jover wrote:
> > On Sun, 2012-11-11 at 21:01:16 +0100, Michael Biebl wrote:
> > The imptcp module seems like has never been available in anything
> > non-Linux, so I've restricted its build in the rules file; the ideal
> > solution here would be to port it to use kqueue which would make it
> > work on most BSDs (that's why I've not bothered with a configure check
> > for epoll). The <sys/klog.h> conditional inclusion should be dependant
> > on the presence of the file, but because I saw another module checking
> > based on OS_LINUX, I just used that instead. The ideal fix for the
> > uptime code would be to use clock_gettime(CLOCK_UPTIME) on FreeBSD
> > and GNU/kFreeBSD, and sysctl kern.boottime on OpenBSD, NetBSD and
> > DragonFlyBSD.
For GNU/Hurd, one should get the task creation time of PID 1 (init);
also the kern.boottime sysctl seems to be available on most (if not all
BSDs, so it might be the most portable solution), rather than special
casing FreeBSDs; I've updated my porting guidelines page to add (more)
information about this:
<http://www.hadrons.org/~guillem/debian/ports/porting>
> Would anyone be interested to address these both issues as outlined by
> guillem? Disabling the code on non-Linux is an option but I would prefer
> if it would just work on the other archs.
I might get to it eventually, but as I don't use rsyslog, no promises
from my part.
thanks,
guillem
Reply to: