Hi guillem, On 12.11.2012 03:24, Guillem Jover wrote: > On Sun, 2012-11-11 at 21:01:16 +0100, Michael Biebl wrote: >> the current version of rsyslog from experimental (7.2.1) FTBFS on >> kfreebsd-*. > >> It would be great if the kfreebsd porters would have a look and provide >> a patch. > > Attached a patch fixing the issues in the code, only build tested on > GNU/kFreeBSD though (w/ the db code disabled). Thanks a lot for the patch. Getting rsyslog to build again everywhere is definitely a step in the right direction. > The imptcp module seems like has never been available in anything > non-Linux, so I've restricted its build in the rules file; the ideal > solution here would be to port it to use kqueue which would make it > work on most BSDs (that's why I've not bothered with a configure check > for epoll). The <sys/klog.h> conditional inclusion should be dependant > on the presence of the file, but because I saw another module checking > based on OS_LINUX, I just used that instead. The ideal fix for the > uptime code would be to use clock_gettime(CLOCK_UPTIME) on FreeBSD > and GNU/kFreeBSD, and sysctl kern.boottime on OpenBSD, NetBSD and > DragonFlyBSD. Would anyone be interested to address these both issues as outlined by guillem? Disabling the code on non-Linux is an option but I would prefer if it would just work on the other archs. > In any case when trying to build rsyslog on GNU/kFreeBSD, it failed to > build the libgrammar convenience library, because it seems the local > libtool script ends up getting truncated during generation. I've not > investigated why that is, but an «autoreconf -f -i» solved the issue. > And something that looked suspicious is that the previous libtool > support was coming from an Ubuntu version, so maybe that's broken > and is the reason. Since the patch touches configure.ac, I will use use dh-autoreconf for now. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Attachment:
signature.asc
Description: OpenPGP digital signature