[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#646957: "mount -o remount,rw" has no effect with kFreeBSD 9.0

On Sun, 30 Oct 2011, Aurelien Jarno wrote:

On Sat, Oct 29, 2011 at 02:27:53PM -0400, Benjamin Kaduk wrote:
On Sat, 29 Oct 2011, Robert Millan wrote:

2011/10/29 Aurelien Jarno <aurelien@aurel32.net>:
Which seems to be kfreebsd-9 related, not busybox related.

This is very likely to be the same bug than the one fixed in kfreebsd-8
by 107_mount_update.diff. This patch has been disabled in kfreebsd-9
(probably because this part has been changed upstream), so this is where
to look first.

Uhm... ISTR it's me who removed that patch during the upgrade.  In any
case, I re-checked, and it seems to me that the code that made iovec
arguments a requirement is no longer present.

Err, I don't see any iovec arguments in the 107_mount_update.diff
that google finds for me as [Glibc-bsd-commits] r3165.

I don't have time to look deeper right now though :-(

Until we are sure it's not a kfreebsd-9 bug, it's better to keep the bug
assigned to kfreebsd-9.

Since stock freebsd is documented as requiring -u ("update") when
changing the mount options of an already-mounted filesystem, it
seems very likely to be a kfreebsd bug.

Requiring -u is a requirement from the userland mount utility. Here we
are talking about the kernel interface. In this case the MNT_UPDATE flag
passed to the nmount() function is ignored if the filesystem was mounted
ro and the update is to mount it rw.

Well, shame on me for not reading the kernel code before posting.
Though, a quick glance at vfs_donmount and vfs_domount{,_update} do not make things terribly clear how this works. I'm not up for grubbing through vfs_getopt today, though, so I'll leave it be.


Reply to: