[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: vmunix throwing ck-collect-session errors.



tags 570015 + patch
--

Great! I have reported to BTS, but let me repeat also here:

   $ ssh  name@kfreebsd  uptime

never fails to provoke a segfault at "kfreebsd" running GNU/kFreeBSD.
Could this merit upgrading to "important"? Could it be that ConsoleKit
mixes GNU/Linux and FreeBSD in autoconf?


Hi,

the freebsd specific code does not handle empty string in environment correctly. Please apply oneliner bellow. It would be nice to also inform upstream.

Please consider uploading it also into testing-proposed-updates.

Thanks

	Petr

--- consolekit/src/ck-sysdeps-freebsd.c
+++ consolekit/src/ck-sysdeps-freebsd.c
@@ -261,6 +261,8 @@
         for (i = 0; penv[i] != NULL; i++) {
                 char **vals;

+                if (!penv[i][0]) continue;
+
                 vals = g_strsplit (penv[i], "=", 2);
                 if (vals != NULL) {
                         g_hash_table_insert (hash,



Reply to: