Re: test of makefs in kfreebsd d-i
On Wed, Aug 05, 2009 at 11:51:18AM +0200, Aurelien Jarno wrote:
> Thorsten Glaser a écrit :
> > On Wed, 5 Aug 2009, Luca Favatella wrote:
> >
> >> It looks like there are no regressions in the produced monolithic and
> >> netboot images.
> >
> > Cool!
> >
> > Should I proceed to upload makefs as-is to Debian? Is there someone
> > here willing to sponsor? Otherwise, Mika Prokop from grml.org has
> > volunteered to do it if I need a sponsor. (I can only maintain it,
> > but NEW must go through a DD.)
> >
>
> I will have a look at the package and upload it if everything is fine.
>
Sorry for the delay, I have finally been able to review your package. It
is basically fine, I have a few minor comments/requests though:
- I have seen that you are using a CVS repository to maintain the
debian/ directory, and that you have problem with the Vcs-CVS.
First of all I don't think the lintian override is appropriate here.
The format you have used is not supported, even if I agree there is
currently no way to represent the URL for a ext server. You should
probably send a mail to debian-devel so that the format is updated
and all related tools changed. In the meanwhile you can live with
the lintian error.
Alternatively or in addition, you can maintain the package using the
glibc-bsd alioth SVN where we maintain BSD related packages, just
ask if you need write access.
- Given there is no upstream tarball, I think it should be a really good
idea to provide a get-orig-source target in the makefile. Please find
a patch below to do that.
- There is some ext2 code in the sources, while makefs does not support
this file system. Is it this code really necessary here?
When we agree on that points, I'll upload the package. Thanks for you
work.
Aurelien
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,20 @@
# dh-make output file, you may use that output file without restriction.
# This special exception was added by Craig Small in version 0.37 of dh-make.
+VERSION=$(shell dpkg-parsechangelog | sed -e '/^Version:/!d' -e 's/^Version: //g' -e 's/-.*//g')
+ORIGFILE=../makefs_$(VERSION).orig.tar.gz
+ORIGDIR=makefs-$(VERSION)
+CVSSERVER=anoncvs@anoncvs.mirbsd.org:/cvs
+CVSMODULE=makefs
+
+get-orig-source:
+ rm -rf $(ORIGDIR)
+ mkdir $(ORIGDIR)
+ cd $(ORIGDIR) && \
+ cvs -d $(CVSSERVER) export -D"$(VERSION) 00:00 +0000" $(CVSMODULE)
+ tar --numeric-owner --owner 0 --group 0 -czf $(ORIGFILE) $(ORIGDIR)
+ rm -rf $(ORIGDIR)
+
CC?= gcc
CFLAGS= -Wall -g
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
Reply to: