[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#464649: freebsd-sendpr: bashism in /bin/sh script



Package: freebsd-sendpr
Severity: important
Version: 3.113+5.3-7
User: debian-release@lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package) 
check I've found your package containing several /bin/sh scripts making 
use of a bashism.

checkbashisms' output:
> possible bashism in ./usr/bin/sendbug line 252 ('((' should be '$(('):
>           { printf ("%-'$l'.'$l's", $0); if ((++i % '$c') == 0) { print ""
> } } possible bashism in ./usr/bin/sendbug line 280 (trap with signal
> numbers): trap 'echo "$COMMAND: Aborting ... saving unfinished PR into
> /tmp/pr.$$"; rm -f $REF ; mv $TEMP /tmp/pr.$$; xs=1; exit' 1 2 3 13 15
> possible bashism in ./usr/bin/sendbug line 355 ('((' should be '$(('): if
> ((++i % '$c') == 0) { printf "\nSEND-PR: " } }
> possible bashism in ./usr/bin/send-pr line 252 ('((' should be '$(('):
>           { printf ("%-'$l'.'$l's", $0); if ((++i % '$c') == 0) { print ""
> } } possible bashism in ./usr/bin/send-pr line 280 (trap with signal
> numbers): trap 'echo "$COMMAND: Aborting ... saving unfinished PR into
> /tmp/pr.$$"; rm -f $REF ; mv $TEMP /tmp/pr.$$; xs=1; exit' 1 2 3 13 15
> possible bashism in ./usr/bin/send-pr line 355 ('((' should be '$(('): if
> ((++i % '$c') == 0) { printf "\nSEND-PR: " } }


Not using bash as /bin/sh would lead to errors. Please be aware that although 
bash is currently the default /bin/sh there's a release goal for Lenny to 
make dash the default /bin/sh[1].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html
https://wiki.ubuntu.com/DashAsBinSh

[1]http://release.debian.org/lenny/goals.txt

Thank you,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html



Reply to: