[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: unix compiler symbol not in NetBSD? (zlib's minunzip)



On Tue, Dec 23, 2003 at 12:00:24PM -0600, Drew Scott Daniels wrote:
> Any comments?
> 
>      Drew Daniels
> 
> --- zlib-1.2.1.orig/debian/patches/010_NetBSD_minizip
> +++ zlib-1.2.1/debian/patches/010_NetBSD_minizip
> @@ -0,0 +1,14 @@
> +This patch is safe, because all Debian systems should be POSIX compliant
> +enough to have <unistd.h> and related headers, whether or not they have
> +'unix' as a compiler symbol (NetBSD, in particular, lacks it).
> +
> +diff -ur zlib-1.1.4.orig/contrib/minizip/Makefile zlib-1.1.4/contrib/minizip/Makefile
> +--- zlib-1.1.4.orig/contrib/minizip/Makefile	2002-10-10 04:24:24.000000000 +0000
> ++++ zlib-1.1.4/contrib/minizip/Makefile	2002-10-10 04:25:09.000000000 +0000
> +@@ -1,5 +1,5 @@
> + CC=cc
> +-CFLAGS=-O2 -g -I../..
> ++CFLAGS=-O2 -g -I../.. -Dunix
> +
> + UNZ_OBJS = miniunz.o unzip.o
> + ZIP_OBJS = minizip.o zip.o

Er. What about it? I wrote it, a while back, and as far as I know both of
the assertions are still true... really, the better answer would be some
sort of auto-detect of what it *actually* wants, but there isn't much to be
done for that.
-- 
Joel Baker <fenton@debian.org>                                        ,''`.
Debian GNU/NetBSD(i386) porter                                       : :' :
                                                                     `. `'
				                                       `-

Attachment: pgpsCSs1GOJ9Z.pgp
Description: PGP signature


Reply to: