[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035349: regression: 'hostname' preseed alias for netcfg/get_hostname takes precedence over DHCP hostname



Control: tag -1 patch

Hi again,

Cyril Brulebois <kibi@debian.org> (2023-05-03):
> In summary:
>  - It looks to me the first patch did make sure hostname=foo is still
>    seen and acted on in userland, using the traditional logic.
>  - It looks to me tweaking it to unset the hostname if it's set should
>    restore “hostname is only a fallback, not actually taking priority”
>    problem, while retaining the “abracadebconf” part.
>  - It looks to me the kernel change should have zero impact on the
>    hostname?=foo case.
> 
> 
> Having performed the quick checking leading to this very mail, I fear
> I might back out of what I thought I was going to do (testing various
> combinations in some systematic manner), and instead: concentrate on
> unsetting hostname in Linux/UTS, run a test or two, upload the
> package, and let the rest of you all check all the combinations you
> want (hostname=foo, hostname?=foo, before/after ---, with or without
> DHCP supplied hostnames, etc.) using daily builds.

It's entirely untested for the time being, but I've tested a few things
inside an installer context, checking how hostname behaves when setting
and when getting the hostname (even if I already alluded to it in the
other bug report), and picking one of two possible options. You can find
details in the comments above the command getting added:
  https://salsa.debian.org/installer-team/preseed/-/commit/2d83a156b3e50e3a35dd9964090967ac1761f85f

I'll probably just find a dnsmasq config to tweak to force hostnames,
check a netboot/gtk/mini.iso against it, and upload if that behaves
better than D-I Bookworm RC 2.

In the meanwhile, if you spot something fishy in the reasoning or in the
implementation, please let me know.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature


Reply to: