[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#989884: isenkram-cli: isenkram-autoinstall-firmware doesn't find any firmware packages



Package: isenkram-cli
Version: 0.46
Severity: serious
Tags: d-i patch
Justification: doesn't fullfil its purpose out of the box
X-Debbugs-Cc: debian-boot@lists.debian.org

Hi,

isenkram-cli has been mentioned a few times on debian-boot@, and I've
looked at it to see if it could help us regarding firmware installation.
I'm tracking such issues under this umbrella bug report (even if I'll
file details later on, using data from two test machines):
  https://bugs.debian.org/989863

Installing isenkram-cli on a brand new machine, itself installed with an
official D-I Bullseye RC 2 (main-only), isenkram-autoinstall-firmware
takes a very long time but fails to find any packages to install.

I've tracked down a number of bugs that explain that, the most important
ones probably being:
 - the condition used to trigger the fallback to Fw-Contents-* files is
   reversed;
 - the fallback code doesn't look into the Fw-Contents-all-* files in
   addition to the Fw-Contents-$arch-* ones.

To illustrate how important it is to look at those, some data:

    kibi@tokyo:~/hack/isenkram.git$ wc -l ./generated/Fw-Contents-{amd64,all}-bullseye-non-free
        91 ./generated/Fw-Contents-amd64-bullseye-non-free
      2113 ./generated/Fw-Contents-all-bullseye-non-free

I'm also fixing a huge performance issue in passing.

The patch series is available in this repository (master branch):
  https://salsa.debian.org/kibi/isenkram


Finally, I haven't seen this return anything:

    appstreamlookup() {
        fwfile="$1"
        appstreamcli what-provides firmware:runtime "$fwfile" | \
    	awk '/Package:/ { print $2}'
    }

I'm no appstream expert though, so I have no idea whether that's an
appstreamcli limitation, a usage problem from the caller side, and/or
some requirements that aren't met on the setup side. It's still a little
surprising to me as both code and comments suggest appstream is the
preferred way to get the information…


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Reply to: