Bug#995209: d-i: partman-basicfilesystems: missing btrfs mount option descriptions
Package: partman-basicfilesystems
Version: 156
Tags: patch
Hello d-i team,
The following mount options are advertised in mountoptions/btrfs from
package partman-btrfs but lack descriptions in
debian/partman-basicfilesystems.templates :
nodatasum
nodatacow
nobarrier
compress
ssd
noacl
notreelog
flushoncommit
Also, select_mountoptions wrongly stops reading the option list when
encountering a missing description, skipping all remaining options
instead of just skipping options with no description. I spotted this
because the "discard" option is not available for btrfs even though it
has a description and is available for other filesystems which support
it (ext4, fat*).
For now, the attached patch does not skip any options and just shows
bare options instead of the missing descriptions.
Q: Which package should provide the descriptions for filesystem-specific
mount options ? partman-basicfilesystems or partman-<filesystem> ?
--- a/select_mountoptions 2021-07-23 19:14:05.000000000 +0200
+++ b/select_mountoptions 2021-09-27 22:37:28.609316256 +0200
@@ -24,12 +24,13 @@
for op in $(cat $optionsfile); do
if db_metaget partman-basicfilesystems/text/$op description && \
[ "$RET" ]; then
- all_options="${all_options:+$all_options, }$op"
- descriptions="${descriptions:+$descriptions, }$RET"
+ :
else
- logger -t partman "Error: no description for mount option $op found; skipping"
- break
+ logger -t partman "Error: no description for mount option $op found"
+ RET="$op"
fi
+ all_options="${all_options:+$all_options, }$op"
+ descriptions="${descriptions:+$descriptions, }$RET"
if [ -f $part/options/$op ]; then
full_options="${full_options:+$full_options,}$(cat $part/options/$op)"
Reply to: