[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991587: marked as done (cdrom-detect: ask hw-detect to skip missing firmware detection)

Your message dated Wed, 28 Jul 2021 07:33:29 +0000
with message-id <E1m8e4H-000GUw-UX@fasolo.debian.org>
and subject line Bug#991587: fixed in cdrom-detect 1.98
has caused the Debian Bug report #991587,
regarding cdrom-detect: ask hw-detect to skip missing firmware detection
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

991587: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991587
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: hw-detect
Version: 1.146
Severity: important
X-Debbugs-Cc: debian-cd@lists.debian.org

I hadn't seen the following when test-installing in loops, since I was
using a netboot-gtk image, but this can be seen with a regular netinst
image produced by debian-cd, since the d-i image used there is slightly
different. I fear this is going to be a rather common annoyance, so I'd
like to get that fixed before the Bullseye release (either in D-I
Bullseye RC3 or in the final D-I release).

On this Dell G3, right after selecting locale settings, cdrom-detect
kicks in and tries to find the installation image to load. Doing so, it
calls hw-detect with this (two occurrences):

    hw-detect cdrom-detect/detect_progress_title || true

which iso-scan can also do (one occurrence):

    hw-detect iso-scan/detect_progress_title || true

At the bottom of hw-detect, there's a check-missing-firmware call, which
can trigger errors and prompts about irrelevant firmware files, e.g.:


(which is about sound support, see firmware-sof-signed.)

While I'm not entirely certain about use-cases around iso-scan, I would
think cdrom-detect should be one of the very few first things to happen
on a system, and that raising errors because of missing firmware files
at this stage wouldn't help: even a firmware-enabled image wouldn't be
mounted and firmware packages wouldn't be available (later, they show up
at /cdrom/firmware).

Therefore, I'm proposing:

 1. Implement support for an environment variable in hw-detect, that
    would disable the check-missing-firmware call.
 2. Set this variable for both hw-detect calls in cdrom-detect's
    postinst. [This should fix the problem I'm seeing.]
 3. Set this variable for the hw-detect call in iso-scan's postinst.
    [Optional, I'm not sure what people are doing before iso-scan kicks
    in; maybe some firmware-holding block devices could be available at
    this stage, so letting the missing firmware detection in place might
    make sense in this case.]

For the avoidance of doubt, hw-detect is called in many places, later
for networking devices and for disks; those are much more likely to
require some firmware files to be available…

Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

--- End Message ---
--- Begin Message ---
Source: cdrom-detect
Source-Version: 1.98
Done: Cyril Brulebois <kibi@debian.org>

We believe that the bug you reported is fixed in the latest version of
cdrom-detect, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 991587@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Cyril Brulebois <kibi@debian.org> (supplier of updated cdrom-detect package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)

Hash: SHA512

Format: 1.8
Date: Wed, 28 Jul 2021 09:14:55 +0200
Source: cdrom-detect
Architecture: source
Version: 1.98
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Closes: 991587
 cdrom-detect (1.98) unstable; urgency=medium
   * Set CHECK_MISSING_FIRMWARE=0 when calling hw-detect. Detecting the
     installation image happens very early in the installation process, and
     it's unlikely to require some firmware to access whatever device holds
     it (and in the case of an unofficial firmware-enabled image, firmware
     packages would be inside the ISO, that hasn't been mounted yet). This
     can avoid prompts about missing firmware files for e.g. sound modules
     (like Intel SOF) early in the installation process (Closes: #991587).
 666dc6e1cab55459302b0f187af98bfb5c185793 1648 cdrom-detect_1.98.dsc
 82ed7ccbfb7b21e58270d872755c842050c0456c 136760 cdrom-detect_1.98.tar.xz
 41b250a21e442cd9f5c25bbdf88ef686a86de7c5 5977 cdrom-detect_1.98_source.buildinfo
 e0b83d7541bd37220ccbde4531bebe753e58684a114fc0f393e8b706441c173f 1648 cdrom-detect_1.98.dsc
 a3ee0b65cd9bc7581fdbbf24445b99e455f4be0ab3412ab15a869e4ca8e18f0f 136760 cdrom-detect_1.98.tar.xz
 d1fac8525eb4704f01d8563cc44d2ae6c4c1e011dbafd3747cc719b9aef363f8 5977 cdrom-detect_1.98_source.buildinfo
 8a684af450e8c7a8815df621e9a002a6 1648 debian-installer optional cdrom-detect_1.98.dsc
 70a8ca5c4943237f2c21bc4df6895b4d 136760 debian-installer optional cdrom-detect_1.98.tar.xz
 7b7bff0cbfad0dc18952729c00a5b525 5977 debian-installer optional cdrom-detect_1.98_source.buildinfo



--- End Message ---

Reply to: