[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#920627: debian-installer: Please update or clarify comment for MTOOLS_SKIP_CHECK=1



Source: debian-installer
Version: 20190118
Severity: wishlist
Tags: patch

Hi,

In/via #823881 it was noticed that mmd(1) had a buggy heuristic
check that can fail the build. On the d-i side this was added with
a prefixing comment:

   # Temporary workaround for #823881:
   export MTOOLS_SKIP_CHECK=1

Whilst mtools in Debian now has a new maintainer (!) and upstream
are pretty good about releases these days, I think this "skip" is
still needed, thus we should update the seemingly misleading
comment to match or at least otherwise clarify the situation.

Patch attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
diff --git a/build/Makefile b/build/Makefile
index 67b5db0..05089ce 100644
--- a/build/Makefile
+++ b/build/Makefile
@@ -53,7 +53,7 @@
 #     `-- vmlinuz
 #
 
-# Temporary workaround for #823881:
+# Skip heuristic check in mmd(1) that can fail the build (see #823881).
 export MTOOLS_SKIP_CHECK=1
 
 # Add to PATH so dpkg will always work, and so local programs will be found.

Reply to: