[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#919982: apt-setup: preseeded installation hangs at "Use a network mirror?"



Hi Wolfgang!

On Wed, Jan 23, 2019 at 11:07:29AM +0100, Wolfgang Schweer wrote:
>
>I'm pretty sure that this is due to the Debian Edu related changes to 
>debian-cd, see: 
>https://salsa.debian.org/images-team/debian-cd/commit/15b482d49e642e21e983dba27a47b4fc2d8b90b4 
>We proposed/did those to be able to have a BD ISO image with COMPLETE=0 
>(for the image to be small enough) with 'bluray/not_complete' instead of 
>'not_complete' written to $CDDIR/.disk/cd_type (the default for the 
>COMPLETE=0 case). The patch had been taken from the former Debian Edu CD 
>build system; obviously some more thinking about the compliance with the 
>more general case would have been good, sorry.
>
>I guess the following change could amend things:
>
>diff --git a/tools/start_new_disc b/tools/start_new_disc
>index 0b64a7e..83838d1 100755
>--- a/tools/start_new_disc
>+++ b/tools/start_new_disc
>@@ -212,11 +212,7 @@ if [ $DISKNUM = 1 ] ; then
>                 echo "bluray/not_complete" > $CDDIR/.disk/cd_type
>             fi
>         else
>-            if [ "$MAXCDS"x = "1"x ]; then
>-                echo "cd/single/not_complete" > $CDDIR/.disk/cd_type
>-            else
>-                echo "cd/not_complete" > $CDDIR/.disk/cd_type
>-            fi
>+            echo "not_complete" > $CDDIR/.disk/cd_type
>         fi
>     fi
>
>Please check.

So I've been looking through this code again, and the corresponding
code in apt-setup that uses these values. Last time I played with
apt-setup, I added a table to describe what d-i will do based on the
information in cd_type, to explain exactly what d-i expects:

# Various different image types look different here:
#
# Image Type                       cd_type
###################################################
# netinst                          "not_complete"
# full CD sets (default desktop)   "full_cd"
# desktop-specific CD images       "full_cd/single"
# DVD                              "dvd"
# bluray                           "bluray"
# multi-arch CD/DVD                "not_complete"
# live                             "live"
#
# It can make sense to offer to scan more media here in most cases,
# but... on live or blu-ray it's unlikely to help; the
# desktop-specific image is designed specifically to work with only a
# single image. Hopefully the following makes sense.

The changes you've imported from the debian-edu fork of debian-cd
clearly don't match up with these, and that's a problem. So *for now*
I'm reverting them so we can build a d-i alpha 5 CD/DVD release that
we're already overdue for. Apologies for not getting back to you
earlier and reviewing the suggested changes back then. That's my fault
for being too busy and not looking at this code before it was merged.

We'll come back to this again shortly. To help with that, could you
describe exactly what debian-edu is expecting here please, i.e. what
the settings in cd_type mean for the debian-edu installer? I'm worried
that we may not have a clear solution here that can match the current
expectations of both d-i and and the debian-edu setup.

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
Who needs computer imagery when you've got Brian Blessed?


Reply to: