Hi, On Sat, Apr 22, 2017 at 10:30:31PM +0200, Holger Wansing wrote: > Geert Stappers wrote: > > Holger Wansing <firstname.lastname@example.org> wrote: > > > And there is nothing like that ATM in the manual. > > > > True. > > I tried with > > --- build/build.sh (revision 70653) > > +++ build/build.sh (working copy) > > @@ -59,7 +59,8 @@ > > if [ -f $PRESEED ] && [ -f preseed.pl ] ; then > > for arch in $architectures; do > > eval arch_destination=$destination > > - ./preseed.pl -r $manual_release $PRESEED >$arch_destination/example-preseed.txt > > + echo '#_preseed_V1' >$arch_destination/example-preseed.txt > > + ./preseed.pl -r $manual_release $PRESEED >>$arch_destination/example-preseed.txt > > done > > fi > > > > > > > > > > > > The attached patch adds the needed paragraph in B.4 chapter at the very > > > > beginning (the already existing content regarding the new header is in B.3). > > > > > > Any objections against me committing the attached patch, to fix the > > > example-preseed.txt file? > > > > No objection. It is better then I patch against the create script. } } No objection. It is better then my patch against the create script. > > Ahh, I see. > > Geert: to be honest, I overlooked your changing in build.sh. > And now, double-checking that, it works. The header is there in > https://d-i.debian.org/manual/example-preseed.txt > > So I have to correct myself a bit: > The example-pressed.txt file would be ok so far, strictly spoken. > > So, the only argument to still change something now, would be: > The whole content of example-preseed.txt is generated from text examples > within the chapter B.4 of the installation-guide. > To be consistent with this, it would require to apply my proposed patch. Indeed > It would also give possibility to explain, what this header line is for. But below the top line. So the file starts with the actual header. > But: Applying my patch would make above's changing in build.sh useless, so > this would have to be reverted, right? Find attached a patch that does _both_ things. Groeten Geert Stappers -- Leven en laten leven
Index: build/build.sh =================================================================== --- build/build.sh (revision 70708) +++ build/build.sh (working copy) @@ -59,8 +59,7 @@ if [ -f $PRESEED ] && [ -f preseed.pl ] ; then for arch in $architectures; do eval arch_destination=$destination - echo '#_preseed_V1' >$arch_destination/example-preseed.txt - ./preseed.pl -r $manual_release $PRESEED >>$arch_destination/example-preseed.txt + ./preseed.pl -r $manual_release $PRESEED >$arch_destination/example-preseed.txt done fi Index: en/appendix/preseed.xml =================================================================== --- en/appendix/preseed.xml (revision 70708) +++ en/appendix/preseed.xml (working copy) @@ -762,6 +762,16 @@ </para><para> +For the &d-i; to be able to automatically detect preseed files, such files +need to start with the <quote>#_preseed_V1</quote> header: + +<informalexample role="example"><screen> +#_preseed_V1 +# Header for installer preseed files for automatical detection of preseedfile +</screen></informalexample> + +</para><para> + Details on how the different Debian Installer components actually work can be found in <xref linkend="module-details"/>.
Description: Digital signature