[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#859438: marked as done (preseed header magic)



Your message dated Tue, 18 Apr 2017 23:04:18 +0000
with message-id <E1d0cAU-0006Sf-1N@fasolo.debian.org>
and subject line Bug#859438: fixed in installation-guide 20170419
has caused the Debian Bug report #859438,
regarding preseed header magic
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
859438: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859438
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: installation-guide
Version: 20161031
Tags: patch stretch


Hi,

The long run goal is to make preseed
being able to identify that it is reading a preseed file.

The wanted way to go is adding header magic.

In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848726
is a bugreport against preseed. This one against installation-guide

Groeten
Geert Stappers

----- Forwarded message from Geert Stappers -----

Date: Mon, 3 Apr 2017 15:40:13 +0200
From: Geert Stappers <stappers@stappers.nl>
To: Pali Rohár <pali.rohar@gmail.com>, 848726@bugs.debian.org
Subject: Re: shebang preseed / header magic

On Sun, Jan 15, 2017 at 11:09:02AM +0100, Pali Rohár wrote:
] ]  Goal is having a "header" which make it possible
] ]  to check that actual a preseed file is being downloaded.
] ]  
] ]  Step 1:
] ]  Document all "stretch" preseed files begining with '#_preseed_V1'
] ]  
] ]  Step 2:
] ]  In "stretch+1", a.k.a. "buster", implement code that checks '#_preseed_V1'
] ]  and informs netbooting user when not found.
] ]  
> 
> Hi! Any progress on this particular problem?

Find attached a patch  against the installation guide.


> I fully agree that pressed file should be identifiable by either some
> magic line or header.

Yes. The challenge now is to get beyond "we didn't need in the past" ...


Index: build/build.sh
===================================================================
--- build/build.sh	(revision 70653)
+++ build/build.sh	(working copy)
@@ -59,7 +59,8 @@
 if [ -f $PRESEED ] && [ -f preseed.pl ] ; then
     for arch in $architectures; do
 	eval arch_destination=$destination
-	./preseed.pl -r $manual_release $PRESEED >$arch_destination/example-preseed.txt
+	echo '#_preseed_V1' >$arch_destination/example-preseed.txt
+	./preseed.pl -r $manual_release $PRESEED >>$arch_destination/example-preseed.txt
     done
 fi
 
Index: en/appendix/preseed.xml
===================================================================
--- en/appendix/preseed.xml	(revision 70653)
+++ en/appendix/preseed.xml	(working copy)
@@ -633,6 +633,18 @@
 
 </para><para>
 
+The file should start with <literal>#_preseed_V1</literal>
+<!--
+  The "should" is for the Stretch release,
+  so later releases use the comment
+  as a magic string to identify a preseed file
+
+  see also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848726
+-->
+
+
+</para><para>
+
 There are a few rules to keep in mind when writing a preconfiguration file.
 
 </para>
@@ -667,6 +679,10 @@
   Some questions take a code as value instead of the English text that is
   shown during installation.
 </para></listitem>
+<listitem><para>
+  Start with <literal>#_preseed_V1</literal>
+  <!-- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848726 -->
+</para></listitem>
 </itemizedlist>
 
 <para>
@@ -682,7 +698,8 @@
 database and the installer's cdebconf database to a single file:
 
 <informalexample><screen>
-$ debconf-get-selections --installer &gt; <replaceable>file</replaceable>
+$ echo "#_preseed_V1" &gt; <replaceable>file</replaceable>
+$ debconf-get-selections --installer &gt;&gt; <replaceable>file</replaceable>
 $ debconf-get-selections &gt;&gt; <replaceable>file</replaceable>
 </screen></informalexample>
 


----- End forwarded message -----
Index: build/build.sh
===================================================================
--- build/build.sh	(revision 70653)
+++ build/build.sh	(working copy)
@@ -59,7 +59,8 @@
 if [ -f $PRESEED ] && [ -f preseed.pl ] ; then
     for arch in $architectures; do
 	eval arch_destination=$destination
-	./preseed.pl -r $manual_release $PRESEED >$arch_destination/example-preseed.txt
+	echo '#_preseed_V1' >$arch_destination/example-preseed.txt
+	./preseed.pl -r $manual_release $PRESEED >>$arch_destination/example-preseed.txt
     done
 fi
 
Index: en/appendix/preseed.xml
===================================================================
--- en/appendix/preseed.xml	(revision 70653)
+++ en/appendix/preseed.xml	(working copy)
@@ -633,6 +633,18 @@
 
 </para><para>
 
+The file should start with <literal>#_preseed_V1</literal>
+<!--
+  The "should" is for the Stretch release,
+  so later releases use the comment
+  as a magic string to identify a preseed file
+
+  see also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848726
+-->
+
+
+</para><para>
+
 There are a few rules to keep in mind when writing a preconfiguration file.
 
 </para>
@@ -667,6 +679,10 @@
   Some questions take a code as value instead of the English text that is
   shown during installation.
 </para></listitem>
+<listitem><para>
+  Start with <literal>#_preseed_V1</literal>
+  <!-- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848726 -->
+</para></listitem>
 </itemizedlist>
 
 <para>
@@ -682,7 +698,8 @@
 database and the installer's cdebconf database to a single file:
 
 <informalexample><screen>
-$ debconf-get-selections --installer &gt; <replaceable>file</replaceable>
+$ echo "#_preseed_V1" &gt; <replaceable>file</replaceable>
+$ debconf-get-selections --installer &gt;&gt; <replaceable>file</replaceable>
 $ debconf-get-selections &gt;&gt; <replaceable>file</replaceable>
 </screen></informalexample>
 

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: installation-guide
Source-Version: 20170419

We believe that the bug you reported is fixed in the latest version of
installation-guide, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 859438@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated installation-guide package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 19 Apr 2017 00:38:24 +0200
Source: installation-guide
Binary: installation-guide-amd64 installation-guide-arm64 installation-guide-armel installation-guide-armhf installation-guide-i386 installation-guide-mips installation-guide-mips64el installation-guide-mipsel installation-guide-ppc64el installation-guide-s390x
Architecture: source all
Version: 20170419
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Description:
 installation-guide-amd64 - Debian installation guide for amd64
 installation-guide-arm64 - Debian installation guide for arm64
 installation-guide-armel - Debian installation guide for armel
 installation-guide-armhf - Debian installation guide for armhf
 installation-guide-i386 - Debian installation guide for i386
 installation-guide-mips - Debian installation guide for mips
 installation-guide-mips64el - Debian installation guide for mips64el
 installation-guide-mipsel - Debian installation guide for mipsel
 installation-guide-ppc64el - Debian installation guide for powerpc
 installation-guide-s390x - Debian installation guide for s390x
Closes: 859150 859438
Changes:
 installation-guide (20170419) unstable; urgency=medium
 .
   [ Samuel Thibault ]
   * Re-enable Dutch translation.  Thanks a lot to Frans Spiesschaert!
   * Document shortcuts for expert, rescue, and automated installation with
     accessibility.
   * Update distrib name about the absence of graphical installer on arm64.
   * Drop the note about USB not being supported on Mustang, that was fixed.
 .
   [ Geert Stappers ]
   * Add header to preseed file. Closes: #859438
 .
   [ Holger Wansing ]
   * Set TMPDIR variable, to get dblatex debugging files removed after pdf
     build. Closes: #859150
Checksums-Sha1:
 9dc0f5770dcc6deaa4ce21c732bd857dec479abd 2853 installation-guide_20170419.dsc
 398de78f5d28e1429ebbd1c3c36f25c39018676b 9819125 installation-guide_20170419.tar.gz
 efe219d11516b639f767024753a596945cfd397b 16602244 installation-guide-amd64_20170419_all.deb
 babb51a3409d091086c7c0446e9faa5ecf76a2de 14927756 installation-guide-arm64_20170419_all.deb
 9577ef990cf883b5290e0d2063e2ba0659314b9f 14931730 installation-guide-armel_20170419_all.deb
 3afebe02367e205957e2e2287917459efe2e527e 15260216 installation-guide-armhf_20170419_all.deb
 267132827db67c384f1c8dbe0b2d072f7276ba32 16646990 installation-guide-i386_20170419_all.deb
 b9f3be1f915a130e174e45e84892adbe3c9c7238 14349246 installation-guide-mips64el_20170419_all.deb
 3abcf93cbe3e3a5d57598c539e56e326d97eee63 14333726 installation-guide-mips_20170419_all.deb
 6de49539f76469fc79ac5de8c1c02fc0cf465207 14355356 installation-guide-mipsel_20170419_all.deb
 1455e998ac7c29843f91905ed858e437c11c0280 14641482 installation-guide-ppc64el_20170419_all.deb
 6f02a48962176fee4316d13826100ff9bc972e55 13183604 installation-guide-s390x_20170419_all.deb
 85f4af2007cdec80602f4d44197395bef79fd1a1 13562 installation-guide_20170419_amd64.buildinfo
Checksums-Sha256:
 ada81666595157e89fc55dafdcf17ebf25b325eb3a22aed09de9750874e825d2 2853 installation-guide_20170419.dsc
 b39053bfa4cc588cb84c7b025adeeea345d408bfcd98667c494762144abebc3b 9819125 installation-guide_20170419.tar.gz
 b4e6eee6c2290c0e8079310a312018e32a4c3ab4a479d6857c82514033055eb8 16602244 installation-guide-amd64_20170419_all.deb
 0a4737a173dce06f21c3c3955c89d5b0512761979de7f3b6d61ba2ac5aa4c2ce 14927756 installation-guide-arm64_20170419_all.deb
 688cb83c0e25845e9e753afe438d24ab9199a7c5fefb376b3f682c1a6a20d3de 14931730 installation-guide-armel_20170419_all.deb
 c146035423b16b030a4ae5214e5e578eb5cc14c9d2a19381a974acd0ddf502de 15260216 installation-guide-armhf_20170419_all.deb
 f12c1c68215ef5fa3c7d38e4b29ac8f1fdceee6e181f5edb136c2d85d9a2131c 16646990 installation-guide-i386_20170419_all.deb
 3fff8735ab65ce3e59a86bd8d83dc7796a71f402439d8bd3f2e7373c68d596e8 14349246 installation-guide-mips64el_20170419_all.deb
 91570dded9dc647d26fbac5d9df85cf1131ef29356fa577243f16e76636cf48c 14333726 installation-guide-mips_20170419_all.deb
 9b63104e0b9cabcda3cb927b7bd145534663378d0ce7256fd25e064b042920f7 14355356 installation-guide-mipsel_20170419_all.deb
 29131b36a2c7b42d4b5128dd9befdc22dcb6c62684d8793aa3d34c7a3b74bc86 14641482 installation-guide-ppc64el_20170419_all.deb
 1cca02c537df38754334754e4cf8ad345067464d2b2e5929ad582262c745bc24 13183604 installation-guide-s390x_20170419_all.deb
 93c256fb8a8da4452298c8e3ac5d89bf0f37073c56739be98b679df9a751cc8c 13562 installation-guide_20170419_amd64.buildinfo
Files:
 2447af5e7cb2a784f36227d302af5061 2853 doc optional installation-guide_20170419.dsc
 1c885a1366f82ea8e4f75f0ce0e2deba 9819125 doc optional installation-guide_20170419.tar.gz
 30fad7507ac9bc9ff533dd64931d8636 16602244 doc optional installation-guide-amd64_20170419_all.deb
 4581f167656b43befcd1f6352c7ddc3b 14927756 doc optional installation-guide-arm64_20170419_all.deb
 cc78894d975cc5fd032b05cd8039ce1c 14931730 doc optional installation-guide-armel_20170419_all.deb
 de362a6e0d9ee3bed40283d5dc2196c3 15260216 doc optional installation-guide-armhf_20170419_all.deb
 6b7f670d0a6655f60632f00d2c7f03b4 16646990 doc optional installation-guide-i386_20170419_all.deb
 6c43012667022d1092ea964bbd6813ec 14349246 doc optional installation-guide-mips64el_20170419_all.deb
 307c02b680aabaa9b51bf33695c0fdd4 14333726 doc optional installation-guide-mips_20170419_all.deb
 74bc778dbbf2e49e796bacaacde11474 14355356 doc optional installation-guide-mipsel_20170419_all.deb
 867b23479e40bf66afda89ca200ba0bb 14641482 doc optional installation-guide-ppc64el_20170419_all.deb
 c96d8f1e9e20e0d9a2bc43e68b770161 13183604 doc optional installation-guide-s390x_20170419_all.deb
 d49f68dedbb589d62e0fb480cd9e9286 13562 doc optional installation-guide_20170419_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEaw+sIYVmRulKotIAoAMZaCdBSIAFAlj2mgcACgkQoAMZaCdB
SIBYkQ//QTz3eiFPO/l6kjGXYyPdzA9+CfBh1h8+yGrsHBAYUZHINoV1aGqHKAkG
RKb/aUCS1LiGEAeDYtzUTm1e+ndFVz5gl4BU74wH46kQMu4ggFOp0LXNesbk7sow
WERLEJDawVAz2UmRDgyeTGQETaD8qFVyrXa6d0vbrbylHQqjhOoCDfdOr99T8cXq
tvUHw5rql9pB0LrsQCvJSzBYYvKMiXWEzCSVp99hdkylL87FI7WInH62cqMwvCxY
ebMSMAvMj8CUpRH+XMGlbp4cE+4ru4ATMXihnzh+hy5lA7QDx39hDjnBcoJAdgD/
LVJtX19ITWkEeHCi0kgBhJBOdRB+die9+RSLG9GCthZsy4NPnZ4t5qm6BHyouaVa
kpP5hRHciA2DjRoHhHLuzR9YrAB2BXiNkbOVYgJ+LI08Dgv5zm/PCHHNnm/74Xcn
wCvfJ3sZiElJaAX+SrdTOcmnElyK0RRnENFNiq+PDDL/VC5EcbOgn0uFb+CnECqv
Gis12U66fknUsygnEJhEXJhvSmqs++j80G1Gdx5mF+y+/Wxen951VyERdlIKaR5u
wilSmFGUAyk8Nf6Tc7cpF2zY/UO1eegSEaP02U7Jz2Nxc3ge+ldnyHWpepPTsy0c
t3T0tDwonL+hRNMVBvfabyB3peOeW2TX/hWs8G03mV2ipFdpr8Y=
=Hqy9
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: