[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#842591: debootstrap-udeb: fails to validate InRelease (BADSIG)



On Sun, Oct 30, 2016 at 05:28:57PM +0100, Cyril Brulebois wrote:
> Package: debootstrap-udeb
> Version: 1.0.85
> Severity: grave
> Justification: renders package unusable
> 
> The (re)addition of InRelease support broke debootstrap(-udeb) in a d-i
> context. The sed|tr|sed dance doesn't kill the final newline, which
> leads to a BAD signature.

The one I proposed certainly did.  It worked fine and was portable.
Just a touch ugly perhaps.

> My original proposal was to use head -c -1, which while not specified by
> posix actually just works. Reasons include:
>  1. Tests agree.
>  2. busybox's coreutils/head.c has:
>                 case 'c':
>                         count_bytes = 1;
> 		…
>                         if (negative_N) {
>                                 if (count_bytes) {
>                                         print_except_N_last_bytes(fp, count);
>                                 } else {
>                                         print_except_N_last_lines(fp, count);
>                                 }
>                         } else {
>                                 print_first_N(fp, count, count_bytes);
>                         }

Well only if you have ENABLE_FEATURE_FANCY_HEAD and it was only added
in 2013, so rather recent addition.

> It might be suboptimal to use this for the time being, as it /might/
> limit portability. On the other hand, the idea was to get a d-i release
> out of the door.
> 
> I'll give it some thoughts in the upcoming hours, and decide how to fix.

-- 
Len Sorensen


Reply to: