[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#844458: bootstrap-base: if debootstrap_script is unset, DEBOOTSTRAP_SCRIPT is set to a directory, breaking the install

Tianon Gravi <tianon@debian.org> writes:

> On 15 November 2016 at 15:36, Philip Hands <phil@hands.com> wrote:
>> This seems to have resulted from the recent change to bootstrap-base to
>> allow the script to be specified only as the codename, but which is not
>> checking whether the debconf variable is actually set.
>> This commit should therefore fix the problem:
>>   http://deb.li/iUtYi
>> I've applied that change to a broken image by hand, and it does solve the problem.
> Doh, sorry I missed this edge case!
> For what it's worth, the proposed change looks legit to me. :)

Glad yo like it, but on re-examination, I'm not so sure -- should the
concatenated path not also be checked to see if it exists?

I'd have thought that one should do something like:

  get debconf variable

  if it has no slashes in it, stick it on the end of the default path

  check if the resulting path exists

Cheers, Phil.
|)|  Philip Hands  [+44 (0)20 8530 9560]  HANDS.COM Ltd.
|-|  http://www.hands.com/    http://ftp.uk.debian.org/
|(|  Hugo-Klemm-Strasse 34,   21075 Hamburg,    GERMANY

Attachment: signature.asc
Description: PGP signature

Reply to: