[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#826665: libdebian-installer: libd-i EFI detection can pass while efibootmgr's/efivar's will fail

Control: tag -1 +pending

On Tue, Jun 07, 2016 at 11:52:01AM -0400, Mathieu Trudel-Lapierre wrote:
>Package: libdebian-installer
>Version: 0.102
>Severity: normal
>Tags: patch
>User: ubuntu-devel@lists.ubuntu.com
>Usertags: origin-ubuntu yakkety ubuntu-patch
>Dear Maintainer,
>EFI detection in libd-i can in some cases pass while efibootmgr will fail to
>set BootEntry due to efivar's checks actually looking for efivars or vars
>instead of just the existence of /sys/firmware/efi.
>In Ubuntu; I'm applying the following patch to libdebian-installer's detection
>  * src/system/efi.c: validate the presence of efivars *or* vars under
>    /sys/firmware/efi to decide whether we should show the system as running
>    in EFI mode; either of these paths is required for efibootmgr to set a
>    BootEntry at the end of installation.
>Admittedly, this can still fail if for some reason efivars or vars are present
>but empty, but this isn't any different than for /sys/firmware/efi itself.
>/sys/firmware/efi/vars should mostly always be around, as it appears to come
>straight from the kernel; /sys/firmware/efi/efivars is typically to be mounted
>by the init system (this happens at least in systemd src/core/mount-setup.c).

This patch makes a lot of sense, applied. Thanks!

Steve McIntyre, Cambridge, UK.                                steve@einval.com
"We're the technical experts.  We were hired so that management could
 ignore our recommendations and tell us how to do our jobs."  -- Mike Andrews

Reply to: