Bug#767682: D-I: installer hangs on re-formatting ext4 partition (having grub in the partition boot record).
On Wed, Feb 10, 2016 at 07:14:07PM +0100, Christian PERRIER wrote:
>Quoting John Paul Adrian Glaubitz (glaubitz@physik.fu-berlin.de):
>> Hi!
>>
>> Coming back to the discussion after having re-assigned the bug to the
>> partman-ext3 package. First of all, this particular bug was reported
>> in Ubuntu as well [1], so I have linked this bug report to the LP bug
>> report.
>>
>> Secondly, I would like to discuss here what is keeping us from adding
>> "-F" to the mkfs.$filesystem call in 50format_ext3. I am currently
>> not seeing any obvious, but I might just be missing something here.
>>
>> However, since we are using "-f" (the btrfs equivalent to mkfs.ext3's
>> "-F") in partman-btrfs [2], I see no apparent reason not to use it if
>> it helps resolving problems people are seeing on certain architectures
>> and partition setups.
>
>Just read the bug log and got convinced.
>So the patch would actually be:
>
>diff --git a/commit.d/format_ext3 b/commit.d/format_ext3
>index fe84d89..d86c545 100755
>--- a/commit.d/format_ext3
>+++ b/commit.d/format_ext3
>@@ -56,7 +56,7 @@ for dev in $DEVICES/*; do
> usage=''
> fi
> if log-output -t partman --pass-stdout \
>- mkfs.$filesystem $device $usage >/dev/null; then
>+ mkfs.$filesystem -F $device $usage >/dev/null; then
> sync
> status=OK
> else
>
>
>Objections for me to commit?
It looks like an obvious fix - go ahead!
--
Steve McIntyre, Cambridge, UK. steve@einval.com
Into the distance, a ribbon of black
Stretched to the point of no turning back
Reply to: