[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#757711: netcfg: promptly kills dhclient, deconfigures interface



Steven Chamberlain <steven@pyro.eu.org> (2014-08-29):
> Please may I commit this to d-i/netcfg (assuming my d-i Git privileges
> include that repository).

(Yes, we have no per-repository settings that I'm aware of.)

> As well as kfreebsd, I expect hurd is currently affected by this bug,
> so this patch would also fix it there.
> 
> Thanks.
> 
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,13 @@
> +netcfg (1.120) UNRELEASED; urgency=medium
> +
> +  [ Steven Chamberlain ]
> +  * Do not kill_dhcp_client after setting the hostname and domain,
> +    otherwise Linux udhcpc will stop renewing its lease, and on other
> +    platforms dhclient will de-configure the network interface
> +    (Closes: #757711, #757988)
> +
> + -- Debian Install System Team <debian-boot@lists.debian.org>  Fri, 29 Aug 2014 22:05:47 +0100
> +
>  netcfg (1.119) unstable; urgency=medium
>  
>    [ Colin Watson ]
> diff --git a/dhcp.c b/dhcp.c
> index aa37bd0..5ef0dbc 100644
> --- a/dhcp.c
> +++ b/dhcp.c
> @@ -614,7 +614,6 @@ int netcfg_activate_dhcp (struct debconfclient *client, struct netcfg_interface
>                  netcfg_write_loopback();
>                  netcfg_write_interface(interface);
>                  netcfg_write_resolv(domain, interface);
> -                kill_dhcp_client();
>                  stop_rdnssd();
>  
>                  return 0;

I'd be slightly happier if Philipp would comment on this since he seems
to be the one having committed this change.

See:
| commit 8802ca520d9e91542d92bbfa5b2fc412a31cf2e2
| Author: Matt Palmer <mpalmer@hezmatt.org>
| Date:   Sun Jan 30 22:29:42 2011 +1100
| 
|     IPv6 support for using rDNS to preseed hostnames
|     
|     A lot of refactoring to make the code cleaner and simpler, but the
|     IPv6-specific changes were actually relatively small.
|     
|     Rebased-and-modified-by: Philipp Kern <pkern@debian.org>

http://anonscm.debian.org/cgit/d-i/netcfg.git/commit/?id=8802ca520d9e91542d92bbfa5b2fc412a31cf2e2

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: