[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Support for sunxi-based ARM systems in d-i



On Sat, 2014-05-10 at 18:46 +0200, Karsten Merker wrote:
> On Thu, May 08, 2014 at 09:20:33PM +0100, Ian Campbell wrote:
> > On Tue, 2014-05-06 at 21:24 +0200, Karsten Merker wrote:
> > > So this means that on an armhf system set up by d-i, the symlinks
> > > are actually in place where we need them for the boot scripts.  I
> > > am very short on time at the moment, so I can't work on the
> > > topic now, but I'll look into it again some time later this week.
> > 
> > It was mostly a case of cherry picking the bits of your patch which were
> > still needed and since I had a few spare moments this evening it took a
> > stab at it (I hope that's ok), the result is attached.
>               ^^^^^^^^^^^^^^^^
> Of course!

Great, I'll try and find time to commit it next week.

> > Works for me on a DI installed system with 3.14-1-armmp built from SVN.
> > My u-boot bootcmd is:
> >         scsi scan;setenv device scsi;setenv partition 0;load ${device}
> >         ${partition} ${scriptaddr} boot.scr;source ${scriptaddr}
> 
> I have run a few tests with your patchset and everything looks ok
> as far as I can tell. Attached is a tiny additional patch to the
> manpage to document the new "--force" option.

Thanks!

> While running the tests I have stumbled over another issue that needs
> to be tackled with regard to d-i.  Currently flash-kernel is not run
> within d-i on an armhf/armmp system, due to
> flash-kernel-installer.isinstallable only allowing it to be run for
> specific archdetect results (covering iop32x, ixp4xx, kirkwood, mx5,
> orion5x and s3c24xx).  Is there a specific reason why machine support
> is checked using a list of archdetect results and not directly via the
> flash-kernel machine db using the according functions (which are both
> available in the flash-kernel-installer udeb)?

I'm not sure why, I suspect hysterical raisins. I've also thought this
odd and agree we should use the machine db. I think the best approach
would be to add generic to XB-Subarchitecture and handle it using the
db, leaving the other subarches as the are.

> 
> Having a separate list based on archdetect means additional information
> to keep up to date and has other problems as well in the context of
> multiplatform kernels: when adding armhf/generic to the list,
> flash-kernel gets run in the "make the system bootable" step, but it
> causes d-i do stop with a rather unspecific error if the particular
> system is technically supported by the armmp kernel but does not have a
> machine db entry in flash-kernel.  Responsible is the following
> fragment of the flash-kernel main() function:
> 
> if ! check_supported "$machine"; then
>         error "Unsupported platform."
> fi
> 
> which exits with a return code of 1 and causes d-i to output
> 
>                 Installation step failed
>  An installation step failed. You can try to run the failing item
>  again from the menu, or skip it and choose something else. The  
>  failing step is: Make the system bootable
> 
> When checking platform support flash-kernel-installer.isinstallable
> based on the flash-kernel machine db, this problem does not occur.

Right.

Ian.


Reply to: