[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#743796: flash-kernel: kirkwood+ should be considered the same as kirkwood



On Sun, 2014-04-06 at 18:24 +0200, Cyril Brulebois wrote:
> John Hughes <john@calva.com> (2014-04-06):
> > Package: flash-kernel
> > Version: 3.3+deb7u2
> > Severity: normal
> > 
> > Dear Maintainer,
> > 
> >    * What led up to the situation?
> > 
> > Built a custom kernel with make-kpkg
> > 
> >    * What exactly did you do (or not do) that was effective (or
> >      ineffective)?
> > 
> > I built it in the directory containing the .git subdirectory
> > 
> >    * What was the outcome of this action?
> > 
> > make-kpkg decided to call the kernel xxxx-kirkwood+-xxxx instead of
> > xxx-kirkwood-xxx, so flash-kernel considers it's no good for my system.
> > 
> >    * What outcome did you expect instead?
> > 
> > flash-kernel should accept an image called xxx-kirkwood+ as valid for
> > a kirkwood system
> 
> AFAICT make-kpkg is not considered supported, at least by the kernel
> team. I suggest you start using the deb-pkg target instead.
[...]

I don't think that will make a difference.  The package name should
always be 'linux-image-' plus the kernel version string (as reported by
uname -r).  The kernel build system appends '+' to the kernel version
string if the source directory is version-controlled and there are
uncommitted changes.  For example, when I build a Debian package to test
Linux 3.2.y, I am using a git repository patched using quilt and I get a
package named something like linux-image-3.2.56-rc1+.  This is appended
*after* any localversion such as John has specified ('-kirkwood').

There is an easy workaround which is to commit changes before building.
But I think it is reasonable to expect flash-kernel to tolerate the '+'.

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: