[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#724931: Please include the patch in git



Hi,

I have researched how to include the needed modules in the initrd.

If I understand it correctly, it would be possible to add the modules as dependencies of cdrom-detect. But that would not be feasible, because the kernel modules have the version of the kernel in their name and therefore the dependencies would have to be updated every time a new kernel is released.

Instead I think the best way is to change the config files for the debian-installer [1] that determine what udebs are included in which initrd. They reside in installer/build/pkg-lists.

For the modules needed for loopmount I attached a patch against the debian-installer. In this patch I just added the loop-, ext4-, ntfs- and udf-modules to all config files that include cdrom-detect. This comes close to making them dependencies of cdrom-detect, but it is much easier, since in these config files one can use the variable ${kernel:Version} and doesn't have to update that manually.

Please include that patch in the debian-installer and then release the new versions of cdrom-detect, apt-setup, hw-detect and mountmedia.

Best regards,
Andreas


1: http://anonscm.debian.org/gitweb/?p=d-i/debian-installer.git;a=tree
diff -rup debian-installer.orig/installer/build/pkg-lists/cd_drivers/common debian-installer/installer/build/pkg-lists/cd_drivers/common
--- debian-installer.orig/installer/build/pkg-lists/cd_drivers/common	2013-11-29 23:57:37.780913000 +0100
+++ debian-installer/installer/build/pkg-lists/cd_drivers/common	2013-11-30 12:37:18.882104469 +0100
@@ -3,3 +3,11 @@ cdrom-retriever
 disk-detect
 cdrom-detect
 file-preseed
+
+# This is for cdrom-detect to be able to loopmount an ISO.
+loop-modules-${kernel:Version}
+
+# This is to enable loopmount/usb-hdd from common non-fat file systems:
+ext4-modules-${kernel:Version}
+ntfs-modules-${kernel:Version}
+udf-modules-${kernel:Version}
diff -rup debian-installer.orig/installer/build/pkg-lists/cdrom/common debian-installer/installer/build/pkg-lists/cdrom/common
--- debian-installer.orig/installer/build/pkg-lists/cdrom/common	2013-11-29 23:57:37.780913000 +0100
+++ debian-installer/installer/build/pkg-lists/cdrom/common	2013-11-30 12:37:30.274111670 +0100
@@ -31,3 +31,11 @@ save-logs
 mountmedia
 
 libfribidi0-udeb
+
+# This is for cdrom-detect to be able to loopmount an ISO.
+loop-modules-${kernel:Version}
+
+# This is to enble loopmount/usb-hdd from common non-fat file systems:
+ext4-modules-${kernel:Version}
+ntfs-modules-${kernel:Version}
+udf-modules-${kernel:Version}
diff -rup debian-installer.orig/installer/build/pkg-lists/cdrom-apus/common debian-installer/installer/build/pkg-lists/cdrom-apus/common
--- debian-installer.orig/installer/build/pkg-lists/cdrom-apus/common	2013-11-29 23:57:37.780913000 +0100
+++ debian-installer/installer/build/pkg-lists/cdrom-apus/common	2013-11-30 12:37:40.694118260 +0100
@@ -24,3 +24,11 @@ save-logs
 mountmedia
 
 libfribidi0-udeb
+
+# This is for cdrom-detect to be able to loopmount an ISO.
+loop-modules-${kernel:Version}
+
+# This is to enable loopmount/usb-hdd from common non-fat file systems:
+ext4-modules-${kernel:Version}
+ntfs-modules-${kernel:Version}
+udf-modules-${kernel:Version}

Reply to: