[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: netcfg's test suite



Cyril Brulebois <kibi@debian.org> (27/09/2012):
> reviewing netcfg (which I decided to unblock{,-udeb} & urgent into
> testing), I noticed that the IPv6 patch set adds a test suite, hurrah
> yay etc.
> 
> But debian/rules says it is not meant to be run at build time, without
> any further comment. How come?

Also, running scan-build on it, it was pointed out that this return
value isn't used in wpa_ctrl_request():
    res = select(ctrl->s + 1, &rfds, NULL, NULL, &tv);

No error checking for select() in wpa_ctrl_pending() either.

(Both functions are in wpa_ctrl.c)

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: