[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Reviewing choose-mirror changes



Le 24/09/2012 16:58, Cyril Brulebois a écrit :

(replying from my work mail, where I don't have the full thread in -boot so I can't notice whether someone else answered)


Hi Christian,

here's choose-mirror's changelog:
|   * Replace XC-Package-Type by package-type.
|
|   [ Updated translations ]
|   * Uyghur (ug.po) by Sahran

However the source debdiff disagrees a little:
|  Mirrors.masterlist |  484 +++++++++++++++++++++++++++++++++++------------------
|  debian/changelog   |    9
|  debian/control     |    4
|  debian/po/bo.po    |    4
|  debian/po/dz.po    |    7
|  debian/po/hr.po    |   15 +
|  debian/po/kn.po    |    4
|  debian/po/sq.po    |    8
|  debian/po/ug.po    |    8

I guess it would be nice to mention Mirrors.masterlist's being updated
in the changelog entry for further uploads.

Hmm, right. The only problem being : how to detect this, as this happens at build time. But, of course, that is feasible (by reviewing changed file in the repository after building, I guess).

Indeed, rebuilding chosse-mirror is currently nearly a must-do before any D-I release, because of this "live" update of Mirrors.masterlist at build time.


On another note, I'd like to make sure the other *.po updates are OK:
apparently those changes are about updating meta data (like revision
date, authors, etc.) but also about dropping parts of the following
strings:
| "US[ Default value for http]

keeping only “US”.

Is that the correct thing to have? I'd guess so since the following
command returns the very same string for every translation:
| egrep 'msgstr.*US' debian/po/*

But I thought I'd ask anyway.
Yes, that's correct. There is even a comment in PO files explaining translators that they should NOT put things between brackets in their translaitons, but some alwayts fail to do that.

We even have a specific check in the spellchecker for this.

The fix has been done by Colin last week. He made the change in the PO files but did not update the Last-Revision-Date field, which explains why the script we use to detect which PO files changes since the last update, didn't notice the change.




Reply to: