Bug#655198: live-installer does not remove live packages in the installed system
On Fri, Jan 13, 2012 at 6:17 PM, Joey Hess <joeyh@debian.org> wrote:
> Rui Miguel P. Bernardo wrote:
>> I've noticed that debian-installer-launcher was not removed in the
>> installed system, as were not removed also live-config, live-boot and
>> others.
>
>> Related to this is the search for /cdrom/live/filesystem.packages-remove
>> file. I suppose the /cdrom is not mounted when
>> finish-install.d/60remove-live-packages is executed
>
> [...]
>
>> 15cdrom-detect: logger -t cdrom-detect "$@"
>> 15cdrom-detect:# Cannot just tell eject to eject /cdrom as it is not compatible
>> 15cdrom-detect:# with busybox umount. Instead, unmount the cdrom first, and then
>> 15cdrom-detect:CDDEV=$(mount | grep "on /cdrom" | cut -d ' ' -f 1)
>> 15cdrom-detect: umount /cdrom || true
>> 15cdrom-detect: db_get cdrom-detect/eject
>> 60remove-live-packages:for list in /cdrom/live/filesystem.packages-remove; do
>
>> If that's the case then something should be done. Move
>> 60remove-live-packages to before 15cdrom-detect (or vice-versa), or just
>> remove "manually" the live packages, or something else.
>
> I agree, it looks broken for 60remove-live-packages to come after cdrom-detect
> cleans up after itself, if it depends on the CD being mounted.
>
>> +do_manual_removal=true
>> +
>> # Remove packages as specified in specific package removal list
>> for list in /cdrom/live/filesystem.packages-remove; do
>> if [ -e $list ]; then
>
> This patch seems correct anyway, so I have applied it, but I don't
> feel it really fixes the bug, the intent seems to be for the list
> of packages to remove to be moved out of live-installer and into
> the creation of the live CD, and this only papers over that not working.
>
> --
> see shy jo
Hi Joey,
I've also found this bug in squeeze this week, while building a
squeeze live image with live-installer. The live-boot package (and the
others that depends on it) is/are not removed after disk install.
I've been using a patched version 34 live-installer in wheezy. It's
patched with fix for this bug and also with workaround for bug 655198
in wheezy.
I've built a squeeze live image with this patched udeb and,
apparently, all works ok in squeeze with live-installer 34+patch; live
packages are removed after the install. The patched live image can be
downloaded from http://www.adrive.com/public/gDgZaK.html and the
patched udeb(s) from github
(https://github.com/rbern/bravance/blob/master/live-installer_35~2.gbpe79f3c~debian6460%2B0_i386.udeb
and https://github.com/rbern/bravance/blob/master/live-installer_35~2.gbpe79f3c~debian6460%2B1_amd64.udeb).
The patched udeb should be copied into config/packages/ directory in
live-build config tree and "--debian-installer live" option included
in "lb config" to build with it.
Because squeeze live-installer also has this bug and building squeeze
with version 34 works ok, I would suggest to release a new 35 version
of live-installer and included it in next 6.0.x release. If that can't
happen, then a fix release with a fresh
live-installer.d/remove-package file with the actual
finish-install.d/60remove-live-packages file (the file was renamed and
changed directory between version 30 and 34) could be done. Diffs:
http://anonscm.debian.org/gitweb/?p=d-i/live-installer.git;a=blobdiff;f=finish-install.d/60remove-live-packages;h=a70466e7e3ce248d509c3b5713c7ff7ce58f7676;hp=2d65ed4604c3ba6db3c474c73ff8c02b71a1d619;hb=HEAD;hpb=33fb8d6830c9b13232597968e2773c2804c723d2
Should I send a patch with this solution in version 30?
I don't know if this can be done, but a fix should be released because
leaving live-* packages in installed systems is not the supposed to
happen.
Reply to: