Re: [PATCH] add support for omap devices

[Hector Oron <hector.oron@gmail.com>]

Hello Sebastian,

2011/6/15 Sebastian Reichel <sre@debian.org>:

> this commit adds support for
>  * Nokia N900
>  * Beagleboard
>  * Pandaboard
> ---
>  debian/changelog               |    9 ++++++++-
>  src/system/subarch-arm-linux.c |    4 +++-
>  2 files changed, 11 insertions(+), 2 deletions(-)

Thanks for the patch, but it looks a bit incomplete. You need to add
omap subarch across debian-installer packages subsystem. As well as
for mx5, we both need to add proper documentation for target boards.

> diff --git a/debian/changelog b/debian/changelog
[..]
> +  * subarch-arm-linux.c: remove omap4 flavour (it's supported by omap)
[..]
> diff --git a/src/system/subarch-arm-linux.c b/src/system/subarch-arm-linux.c
> index f63bb0b..b052294 100644
> --- a/src/system/subarch-arm-linux.c
> +++ b/src/system/subarch-arm-linux.c
> @@ -15,7 +15,6 @@ struct map {
>  static const char *supported_generic_subarches[] = {
>     "dove",
>     "omap",
> -    "omap4",

While this might come from an ubuntuism, please leave it there, it is
harmless for Debian purpose and if you take it out it might break our
cousin distribution. For that same reason, mx51 is still there, but
not used across Debian.

>     "mx51",
>     "mx5",
>     NULL

I am not applying this patch, but please keep working towards a
complete system and let's not forget about documentation updates.

Kind regards,
-- 
 Héctor Orón  -.. . -... .. .- -.   -.. . ...- . .-.. --- .--. . .-.

<free spam>
-- Would you like to make a donation for Debian Conference?
   ** http://debconf11.debconf.org/payments.xhtml **
</free spam>