[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#628084: cdebconf: tasksel debconf does not start in d-i



Samuel Thibault <sthibault@debian.org> wrote:
Package: cdebconf
Version: 0.156~0
Severity: important

Hello,

I've built the current git version of cdebconf and built d-i CDs, it
seems the latest changes make tasksel's debconf not start: with 0.155,
it does start, but with 0.156~0 pkgsel calls tasksel, tasksel starts its
backend, which does the db_* calls, db_input and db_go, but no question
appears at all and the return value is empty, and thus tasksel doesn't
install anything.

Most changes in 0.156~0 are not in the udeb, except the "Implement
handling of multiple flags in the rfc822db backend." change, maybe there
is a small typo or something like this there. At least one difference I
can see is that when there is no flag, "Flags:\n" is output instead of
"Flags: \n", but maybe the bug is hiding in parse_flags too: there are a
few odd things:
< br />if (!string)
return;

Doesn't the compiler warn that a return value should be specified? It
should be 0 here, and that might be exactly the case where tasksel
loses, because the tasksel/first template is not preloaded, it is loaded
by hand by the tasksel debconf backend.

Also,

while (*wc == ' ' || *wc == '\t' || *wc == '\0')
{
wc++;
}

if the string is "Flags: foo " with a trailing space, the loop will not
stop. wc should probably be set to delim+1 (finished not being 1 assures
us that *delim was not \0) and drop *wc == 0 from the while loop above.

Samuel

-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.39 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages cdebconf depends on:
ii debconf 1.5.39 Debian configuration management sy
ii libc6 2.13-4 Embedded GNU C Library: Shared lib
ii libdebian-installer4 0.77+squeeze2 Library of common debian-installer
ii libnewt0.52 0.52.11-2 Not Erik's Windowing Toolkit - tex
ii libslang2 2.2.4-2 S-Lang programming library - runti
ii libtextwrap1 0.1-11 text-wrapping library with i18n -

cdebconf recommends no packages.

Versions of packages cdebconf suggests:
pn cdebconf-gtk <none> (no description available)

-- no debconf information

--
Samuel Thibault <samuel.thibault@fnac.net>
<g> r: et la marmotte, elle écrit un papier IPDPS




Hi Samuel,

Thanks for the report. Since I made this path I'll take all the blame for it. The return without value was already noticed and I sent a patch for it. You're also right about the loop, and I'll submit a patch as well as soon as I get access to something more practical than my phone for that.

Regis
--
Sent from my phone. Please excuse my brevity.
Reply to: