Feiran Zheng wrote: > The MINIX detection criterial is fairly old, no recent MINIX installation can be detected correctly. > As we are developing some new boot features of MINIX (Multiboot compliant for example), we are also > trying to make configuring GRUB easier, as a result the detection of os-prober is patched. > > The patch is as below: > > Index: packages/os-prober/os-probes/mounted/x86/80minix > =================================================================== > --- packages/os-prober/os-probes/mounted/x86/80minix (revision 64312) > +++ packages/os-prober/os-probes/mounted/x86/80minix (working copy) > @@ -7,11 +7,20 @@ > dir="$2" > type="$3" > > -if [ "$type" = minix ] && [ -f "$dir/minix" ]; then > - # XXX will chain loading work? > - label="$(count_next_label Minix)" > - result "$partition:Minix:$label:chain" > - exit 0 > +if [ "$type" = minix ] || [ "$type" = ext2 ] ; then > + if [ -e "$dir/boot/image_big" ]; then > + if [ -e "$dir/boot/image_latest" ]; then Thanks for the patch. Wouldn't it make sense to retain the check for the /minix file, in order to still be able to detect historical minix installations? (Also, "/boot/image_big" and "/boot/image_latest" are awefully generic names to go by..) > + boot="minix" > + else > + boot="chain" Note that grub-installer would also need to be patched to generate the right grub configs to boot minix in the case where the existing chain loader configs are not used. I guess this would look much like the handling of booting linux does, if I understand what you mean by "Multiboot compliant". -- see shy jo
Attachment:
signature.asc
Description: Digital signature