Re: [PATCH] hw-detect: Do not attempt to load ide-generic if paravirt is active.
Hello Ian,
On Thu, Sep 10, 2009 at 6:24 PM, Ian Campbell <ijc@hellion.org.uk> wrote:
> On Mon, 2009-08-31 at 17:05 +0100, Ian Campbell wrote:
>>
>> It's only legacy (non-PnP) ISA drivers of which AFAIK ide-generic is
>> the only one d-i tries to load by default
>
> This made me wonder why we even need to report failure to load
> ide-generic to the user, after all if it loads but doesn't find any
> hardware we don't report a failure in that case. Since there is no way
> to probe for the h/w the driver is being loaded speculatively anyway.
>
> With that in mind how about this patch?
>
> ---
> Subject: hw-detect: do not report failure to load ide-generic to the user.
>
> There is no way to probe for the need to load ide-generic but if it
> fails then it must be unnecessary and there is no need to pop up an
> error dialog to inform the user.
>
> Only log the failure instead.
I support the idea and it looks like the most correct way of dealing with it.
If no one objects, please go ahead and commit it.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Reply to: